Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Unified Diff: Source/bindings/core/v8/custom/V8WindowCustom.cpp

Issue 1121703002: bindings: Uses V8's named property interceptor for Window. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Synced. Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/core/v8/custom/V8WindowCustom.cpp
diff --git a/Source/bindings/core/v8/custom/V8WindowCustom.cpp b/Source/bindings/core/v8/custom/V8WindowCustom.cpp
index 18fa0f9846b509a19ce6d5f54c0e2cd3282e84b1..c4e75c2e34a3c8d10530f8ae8ed9e5a3b2bfca57 100644
--- a/Source/bindings/core/v8/custom/V8WindowCustom.cpp
+++ b/Source/bindings/core/v8/custom/V8WindowCustom.cpp
@@ -300,9 +300,6 @@ static bool installTestInterfaceIfNeeded(LocalFrame& frame, v8::Local<v8::String
void V8Window::namedPropertyGetterCustom(v8::Local<v8::Name> name, const v8::PropertyCallbackInfo<v8::Value>& info)
{
- if (!name->IsString())
- return;
-
auto nameString = name.As<v8::String>();
DOMWindow* window = V8Window::toImpl(info.Holder());
if (!window)
@@ -324,16 +321,6 @@ void V8Window::namedPropertyGetterCustom(v8::Local<v8::Name> name, const v8::Pro
return;
}
- // Search IDL functions defined in the prototype
- if (!info.Holder()->GetRealNamedProperty(info.GetIsolate()->GetCurrentContext(), nameString).IsEmpty())
- return;
-
- // Frame could have been detached in call to GetRealNamedProperty.
- frame = window->frame();
- // window is detached.
- if (!frame)
- return;
-
// If the frame is remote, the caller will never be able to access further named results.
if (!frame->isLocalFrame())
return;

Powered by Google App Engine
This is Rietveld 408576698