win: Work on reducing number of style plugin warnings.

chrome/common/importer/importer_data_types.h

Index: chrome/common/importer/importer_data_types.h
diff --git a/chrome/common/importer/importer_data_types.h b/chrome/common/importer/importer_data_types.h
index 98ecc9bb030704abf1aa0aee1a035bbcaef4f167..9b588d6323b66224eb700636831e423b3168e843 100644
--- a/chrome/common/importer/importer_data_types.h
+++ b/chrome/common/importer/importer_data_types.h
@@ -59,6 +59,9 @@ struct SearchEngineInfo {
 #if defined(OS_WIN)
 // Contains the information read from the IE7/IE8 Storage2 key in the registry.
 struct ImporterIE7PasswordInfo {
+  ImporterIE7PasswordInfo();
+  ~ImporterIE7PasswordInfo();

[Peter Kasting, 2015/05/01 02:42:01]

Most of these changes make sense, but this one doesn't.  While we should have an
explicit destructor if there's an explicit constructor, in this case there
wasn't an explicit either.  It doesn't seem reasonable to require explicit
(empty) constructors for data-only structs, even when they have non-POD members.

[Nico, 2015/05/01 02:46:37]

There are three classes with constructors in this class. The implicit
constructor and destructor have nontrivial code size, so they're going out of
line. (Note that this has been enforced on non-win for years, this is just doing
the same thing on win)

[Peter Kasting, 2015/05/01 03:48:32]

Is there a way to make that border between trivial and nontrivial code size
clear to the reader?  I'm aware of that general rule, but it wasn't clear to me
(and still wouldn't be if I came across this code) that that's the reason for
the out-of-line definition here.

+
   // Hash of the url.
   std::wstring url_hash;