Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 112163004: create tools/tests/run_all.py to run all our Python self-tests within tools (Closed)

Created:
7 years ago by epoger
Modified:
7 years ago
Reviewers:
scroggo, rmistry
CC:
skia-review_googlegroups.com, scroggo
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

create tools/tests/run_all.py to run all our Python self-tests within tools Eventually, we want all of these self-tests to be written in Python; this change makes it easier for us to add new Python self-tests, and discourages the addition of bash self-tests. BUG=skia:677, skia:1943 NOTRY=True Committed: http://code.google.com/p/skia/source/detail?r=12775

Patch Set 1 #

Total comments: 2

Patch Set 2 : fix copyright stanza #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -32 lines) Patch
M tools/tests/run.sh View 2 chunks +19 lines, -13 lines 0 comments Download
A tools/tests/run_all.py View 1 1 chunk +20 lines, -0 lines 0 comments Download
M tools/tests/skimage_self_test.py View 7 chunks +11 lines, -19 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
epoger
Ready for review at patchset 1.
7 years ago (2013-12-18 22:09:36 UTC) #1
scroggo
lgtm https://codereview.chromium.org/112163004/diff/1/tools/tests/run_all.py File tools/tests/run_all.py (right): https://codereview.chromium.org/112163004/diff/1/tools/tests/run_all.py#newcode2 tools/tests/run_all.py:2: # Copyright (c) 2013 The Chromium Authors. All ...
7 years ago (2013-12-18 22:32:03 UTC) #2
epoger
https://codereview.chromium.org/112163004/diff/1/tools/tests/run_all.py File tools/tests/run_all.py (right): https://codereview.chromium.org/112163004/diff/1/tools/tests/run_all.py#newcode2 tools/tests/run_all.py:2: # Copyright (c) 2013 The Chromium Authors. All rights ...
7 years ago (2013-12-19 18:22:07 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/epoger@google.com/112163004/20001
7 years ago (2013-12-19 18:22:25 UTC) #4
commit-bot: I haz the power
7 years ago (2013-12-19 18:22:39 UTC) #5
Message was sent while issue was closed.
Change committed as 12775

Powered by Google App Engine
This is Rietveld 408576698