Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(592)

Issue 1121493004: [Android WebView] Remove AndroidWebViewTelemetryShell. (Closed)

Created:
5 years, 7 months ago by timvolodine
Modified:
5 years, 6 months ago
CC:
android-webview-reviews_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android WebView] Remove AndroidWebViewTelemetryShell. This patch removes AndroidWebViewTelemetryShell which has been superseded by AndroidWebViewShell. BUG=483439 Committed: https://crrev.com/e16e77720af21f68c281d329b88ef223e461d0de Cr-Commit-Position: refs/heads/master@{#335025}

Patch Set 1 #

Patch Set 2 : rebase #

Messages

Total messages: 13 (4 generated)
timvolodine
5 years, 7 months ago (2015-05-01 14:23:32 UTC) #2
timvolodine
On 2015/05/01 14:23:32, timvolodine wrote: torne: ping ;) does this look ok to you? this ...
5 years, 6 months ago (2015-06-12 11:06:43 UTC) #3
Torne
lgtm
5 years, 6 months ago (2015-06-12 11:30:12 UTC) #4
timvolodine
+jochen@: for build/all.gyp
5 years, 6 months ago (2015-06-18 12:00:29 UTC) #6
jochen (gone - plz use gerrit)
lgtm
5 years, 6 months ago (2015-06-18 12:57:23 UTC) #7
timvolodine
thanks! ok the perf bot is now running with the new shell, so should be ...
5 years, 6 months ago (2015-06-18 13:08:57 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1121493004/20001
5 years, 6 months ago (2015-06-18 13:09:54 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 6 months ago (2015-06-18 13:14:36 UTC) #12
commit-bot: I haz the power
5 years, 6 months ago (2015-06-18 13:15:23 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e16e77720af21f68c281d329b88ef223e461d0de
Cr-Commit-Position: refs/heads/master@{#335025}

Powered by Google App Engine
This is Rietveld 408576698