Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(666)

Unified Diff: Source/modules/accessibility/AXLayoutObject.cpp

Issue 1121473004: Expose scroll containers via accessibility APIs. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Add remaining asserts to test Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/modules/accessibility/AXLayoutObject.cpp
diff --git a/Source/modules/accessibility/AXLayoutObject.cpp b/Source/modules/accessibility/AXLayoutObject.cpp
index b4ecf0ac24d8cbe2e101e78eb8ce289ecc374fdb..c1e52d0f0ef40053bb9943766925622906cd54ea 100644
--- a/Source/modules/accessibility/AXLayoutObject.cpp
+++ b/Source/modules/accessibility/AXLayoutObject.cpp
@@ -687,6 +687,9 @@ bool AXLayoutObject::computeAccessibilityIsIgnored(IgnoredReasons* ignoredReason
if (!ariaAccessibilityDescription().isEmpty())
return false;
+ if (isScrollableContainer())
+ return false;
+
// By default, objects should be ignored so that the AX hierarchy is not
// filled with unnecessary items.
return true;
@@ -1648,19 +1651,6 @@ void AXLayoutObject::setValue(const String& string)
toHTMLTextAreaElement(*node()).setValue(string);
}
-// FIXME: This function should use an IntSize to avoid the conversion below.
-void AXLayoutObject::scrollTo(const IntPoint& point) const
-{
- if (!m_layoutObject || !m_layoutObject->isBox())
- return;
-
- LayoutBox* box = toLayoutBox(m_layoutObject);
- if (!box->canBeScrolledAndHasScrollableArea())
- return;
-
- box->scrollToOffset(IntSize(point.x(), point.y()));
-}
-
//
// Notifications that this object may have changed.
//

Powered by Google App Engine
This is Rietveld 408576698