Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(460)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1121473004: Expose scroll containers via accessibility APIs. (Closed)

Created:
5 years, 7 months ago by dmazzoni
Modified:
5 years, 7 months ago
Reviewers:
dglazkov, aboxhall
CC:
aboxhall, blink-reviews, dglazkov+blink, dmazzoni, je_julie(Not used), nektarios
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Expose scroll containers via accessibility APIs. Ensure that any AXObject that's scrollable is not ignored, and then expose public AX APIs to get the current, minimum, and maximum scroll offsets and to change them. BUG=483653, 484878 NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=195338

Patch Set 1 #

Patch Set 2 : Add remaining asserts to test #

Total comments: 2

Patch Set 3 : Rebase #

Patch Set 4 : Move scrolling logic from ScrollView to WebArea #

Total comments: 2

Patch Set 5 : Rebase, remove dup comment #

Patch Set 6 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+177 lines, -40 lines) Patch
M LayoutTests/TestExpectations View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
A LayoutTests/accessibility/scroll-containers.html View 1 2 3 1 chunk +50 lines, -0 lines 0 comments Download
M Source/modules/accessibility/AXLayoutObject.h View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/accessibility/AXLayoutObject.cpp View 1 2 3 4 3 chunks +7 lines, -15 lines 0 comments Download
M Source/modules/accessibility/AXObject.h View 1 2 3 4 2 chunks +10 lines, -4 lines 0 comments Download
M Source/modules/accessibility/AXObject.cpp View 1 2 3 4 7 chunks +61 lines, -13 lines 0 comments Download
M Source/modules/accessibility/AXScrollView.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/accessibility/AXScrollView.cpp View 1 chunk +0 lines, -6 lines 0 comments Download
M Source/web/WebAXObject.cpp View 1 2 3 4 1 chunk +40 lines, -0 lines 0 comments Download
M public/web/WebAXObject.h View 1 2 3 4 2 chunks +8 lines, -0 lines 0 comments Download

Messages

Total messages: 20 (9 generated)
dmazzoni
5 years, 7 months ago (2015-05-01 22:25:35 UTC) #2
aboxhall
lgtm https://codereview.chromium.org/1121473004/diff/20001/Source/modules/accessibility/AXObject.cpp File Source/modules/accessibility/AXObject.cpp (right): https://codereview.chromium.org/1121473004/diff/20001/Source/modules/accessibility/AXObject.cpp#newcode1016 Source/modules/accessibility/AXObject.cpp:1016: // Scrollable containers. Double comment? https://codereview.chromium.org/1121473004/diff/20001/Source/modules/accessibility/AXObject.cpp#newcode1021 Source/modules/accessibility/AXObject.cpp:1021: return ...
5 years, 7 months ago (2015-05-01 23:05:43 UTC) #3
dmazzoni
+mkwst for public/web
5 years, 7 months ago (2015-05-01 23:18:48 UTC) #5
dmazzoni
PTAL. This wasn't quite enough to make it possible to scroll the main frame, so ...
5 years, 7 months ago (2015-05-05 22:13:31 UTC) #6
dmazzoni
+dglazkov instead of mkwst for owners review of public/
5 years, 7 months ago (2015-05-05 22:14:51 UTC) #8
dglazkov
lgtm https://codereview.chromium.org/1121473004/diff/60001/Source/modules/accessibility/AXObject.cpp File Source/modules/accessibility/AXObject.cpp (right): https://codereview.chromium.org/1121473004/diff/60001/Source/modules/accessibility/AXObject.cpp#newcode1041 Source/modules/accessibility/AXObject.cpp:1041: // Do we need both of these comments?
5 years, 7 months ago (2015-05-07 18:59:09 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1121473004/80001
5 years, 7 months ago (2015-05-13 22:07:37 UTC) #12
dmazzoni
https://codereview.chromium.org/1121473004/diff/60001/Source/modules/accessibility/AXObject.cpp File Source/modules/accessibility/AXObject.cpp (right): https://codereview.chromium.org/1121473004/diff/60001/Source/modules/accessibility/AXObject.cpp#newcode1041 Source/modules/accessibility/AXObject.cpp:1041: // On 2015/05/07 18:59:08, dglazkov wrote: > Do we ...
5 years, 7 months ago (2015-05-13 22:07:38 UTC) #13
commit-bot: I haz the power
Failed to commit the patch. Sending LayoutTests/TestExpectations Adding LayoutTests/accessibility/scroll-containers.html Sending Source/modules/accessibility/AXLayoutObject.cpp Sending Source/modules/accessibility/AXLayoutObject.h Sending Source/modules/accessibility/AXObject.cpp ...
5 years, 7 months ago (2015-05-14 00:15:42 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1121473004/100001
5 years, 7 months ago (2015-05-14 05:13:08 UTC) #19
commit-bot: I haz the power
5 years, 7 months ago (2015-05-14 05:17:22 UTC) #20
Message was sent while issue was closed. 
Committed patchset #6 (id:100001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=195338

Powered by Google App Engine
This is Rietveld 408576698