ui/resources/BUILD.gn - Issue 1121453004: Fix GN visibility for a few targets that are compiled by default in a GN build.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/resources/BUILD.gn

Issue 1121453004: Fix GN visibility for a few targets that are compiled by default in a GN build. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@content_unittests

Patch Set: fix build file Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ui/resources/BUILD.gn

diff --git a/ui/resources/BUILD.gn b/ui/resources/BUILD.gn

index 538668cef9fd6b137fee4760450fee675b9926e2..b73e0db9c4a97c60d44f005305a693bd7d931841 100644

--- a/ui/resources/BUILD.gn

+++ b/ui/resources/BUILD.gn

@@ -128,7 +128,10 @@ repack("repack_ui_test_pak") {

# copied, because it causes leaks from allocations within system libraries when

# trying to load non-string resources. http://crbug.com/413034.

repack("repack_ui_test_mac_locale_pack") {

- visibility = [ ":ui_test_pak" ]

+ visibility = [

+ ":ui_test_pak",

+ "//:gn_visibility", # TODO(GYP): this shouldn't be necessary.

+ ]

sources = [

"$root_gen_dir/ui/strings/app_locale_settings_en-US.pak",

« no previous file with comments | « build/config/sanitizers/BUILD.gn ('k') | no next file » | no next file with comments »