Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Side by Side Diff: ui/resources/BUILD.gn

Issue 1121453004: Fix GN visibility for a few targets that are compiled by default in a GN build. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@content_unittests
Patch Set: fix build file Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « build/config/sanitizers/BUILD.gn ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//tools/grit/grit_rule.gni") 5 import("//tools/grit/grit_rule.gni")
6 import("//tools/grit/repack.gni") 6 import("//tools/grit/repack.gni")
7 7
8 # GYP version: ui/resources/ui_resources.gyp:ui_resources 8 # GYP version: ui/resources/ui_resources.gyp:ui_resources
9 group("resources") { 9 group("resources") {
10 deps = [ 10 deps = [
(...skipping 110 matching lines...) Expand 10 before | Expand all | Expand 10 after
121 "//ui/chromeos/strings", 121 "//ui/chromeos/strings",
122 ] 122 ]
123 } 123 }
124 } 124 }
125 125
126 # Repack just the strings for the framework locales on Mac and iOS. This 126 # Repack just the strings for the framework locales on Mac and iOS. This
127 # emulates repack_locales.py, but just for en-US. Note ui_test.pak is not simply 127 # emulates repack_locales.py, but just for en-US. Note ui_test.pak is not simply
128 # copied, because it causes leaks from allocations within system libraries when 128 # copied, because it causes leaks from allocations within system libraries when
129 # trying to load non-string resources. http://crbug.com/413034. 129 # trying to load non-string resources. http://crbug.com/413034.
130 repack("repack_ui_test_mac_locale_pack") { 130 repack("repack_ui_test_mac_locale_pack") {
131 visibility = [ ":ui_test_pak" ] 131 visibility = [
132 ":ui_test_pak",
133 "//:gn_visibility", # TODO(GYP): this shouldn't be necessary.
134 ]
132 135
133 sources = [ 136 sources = [
134 "$root_gen_dir/ui/strings/app_locale_settings_en-US.pak", 137 "$root_gen_dir/ui/strings/app_locale_settings_en-US.pak",
135 "$root_gen_dir/ui/strings/ui_strings_en-US.pak", 138 "$root_gen_dir/ui/strings/ui_strings_en-US.pak",
136 ] 139 ]
137 140
138 output = "$root_out_dir/ui/en.lproj/locale.pak" 141 output = "$root_out_dir/ui/en.lproj/locale.pak"
139 142
140 deps = [ 143 deps = [
141 "//ui/strings", 144 "//ui/strings",
142 ] 145 ]
143 } 146 }
OLDNEW
« no previous file with comments | « build/config/sanitizers/BUILD.gn ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698