Fix GN visibility for a few targets that are compiled by default in a GN build.

BUILD.gn

 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 # This is the root build file for GN. GN will start processing by loading this
 # file, and recursively load all dependencies until all dependencies are either
 # resolved or known not to exist (which will cause the build to fail). So if
 # you add a new build file, there must be some path of dependencies from this
 # file to your new one or GN won't know about it.
 
 import("//build/config/crypto.gni")
 import("//build/config/features.gni")
 import("//build/config/ui.gni")
 import("//build/module_args/v8.gni")
 
 if (is_android) {
   import("//build/config/android/config.gni")
 }
 
 declare_args() {
   # A list of extra dependencies to add to the root target. This allows a
   # checkout to add additional targets without explicitly changing any checked-
   # in files.
   root_extra_deps = []
 }
 
-# This file defines the following three main targets:
+# This file defines the following four main targets:
 #
 # "both_gn_and_gyp" should list every root target (target that nothing else
 # depends on) built by GN that is also built in the GYP build.
 #
 # "gn_all" should (transitively) cause everything to be built; if you run
 # 'ninja gn_all' and then 'ninja all', the second build should do no work.
 #
 # "gn_only" should list every root target that is *not* intended to be built
 # in a GYP build. Because GN has different rules for deciding what an 'all'
 # build is, this may end up including targets that are actually defined in a
 # GYP build but not dependencies of GYP's "all" (and so not actually built).
 #
+# "gn_visibility": targets that are normally not visible to top-level targets,
+# but are built anyway by "all". Since we don't want any such targets, we
+# have this placeholder to make sure hidden targets that aren't otherwise
+# depended on yet are accounted for.
+#
 # TODO(GYP): crbug.com/481694. Make sure that the above is true and there are
 # scripts run on the bots that enforce this. Once the GYP migration is over,
 # we can collapse all of these targets as desired.
 
 group("gn_all") {
   testonly = true
 
   deps = [
     ":both_gn_and_gyp",
     ":gn_only",
+    ":gn_visibility",
   ]
 }
 
 # The "both_gn_and_gyp" target should reflect every target that is built
 # in both the GN and GYP builds, and ideally it should match the
 # "both_gn_and_gyp" target in build/gn_migration.gypi line-for-line.
 #
 # TODO(GYP): Add build steps that check and enforce this on the bots.
 group("both_gn_and_gyp") {
   testonly = true
@@ skipping 634 matching lines @@
       "//third_party/mojo/src/mojo/public/python:packaged_application",
       "//third_party/mojo/src/mojo/public/python:packaged_bindings",
       "//third_party/mojo/src/mojo/public/cpp/application:test_support_standalone",
       "//third_party/mojo_services/src/accessibility/public/interfaces:interfaces_python",
     ]
   }
 }
 
 group("gn_visibility") {
   deps = [
-    # "//build/config/sanitizers:options_sources",
+    "//build/config/sanitizers:options_sources",
+
     # "//third_party/pdfium:pdfium_embeddertests",  # TODO(GYP): visibility?
     # "//third_party/pdfium:pdfium_unittests",  # TODO(GYP): visibility?
-    # "//ui/resources:repack_ui_test_mac_locale_pack",
+
+    "//ui/resources:repack_ui_test_mac_locale_pack",
+
     # "//v8:v8_snapshot",  # TODO(GYP): visibility?
     # "//v8:postmortem-metadata",  # TODO(GYP): visibility?
   ]
 }
 
 if (is_linux) {
   # This group corresponds to the list of tests run on the waterfall for
   # desktop Linux GYP builds from testing/buildbot/chromium.linux.json. It's
   # here to help track GYP -> GN conversion progress.
   group("linux_default_tests") {
@@ skipping 124 matching lines @@
       "//ui/views:views_unittests",  # TooltipControllerTest failures
       "//ui/wm:wm_unittests",  # PASSES 4/21/2015
       "//url:url_unittests",  # PASSES 4/17/2015
 
       # TODO(GYP) nacl_integration
       # TODO(GYP) telemetry_perf_unittests
       # TODO(GYP) telemetry_unittests
     ]
   }
 }