Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(472)

Issue 1121453003: Revert of Wrap v8natives.js into a function. (Closed)

Created:
5 years, 7 months ago by Michael Achenbach
Modified:
5 years, 7 months ago
Reviewers:
Yang, Jakob Kummerow
CC:
v8-dev, Yang
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Wrap v8natives.js into a function. (patchset #2 id:20001 of https://codereview.chromium.org/1109343004/) Reason for revert: [Sheriff] Speculative revert for breaking layout tests, e.g.: http://build.chromium.org/p/client.v8/builders/V8-Blink%20Linux%2064%20%28dbg%29/builds/2682 See. e.g.: https://storage.googleapis.com/chromium-layout-test-archives/V8-Blink_Win/3130/layout-test-results/http/tests/websocket/workers/worker-reload-diff.txt Original issue's description: > Wrap v8natives.js into a function. > > R=jkummerow@chromium.org > > Committed: https://crrev.com/ee1b39b4303829e6c6805fe8b2f2602b13f6463a > Cr-Commit-Position: refs/heads/master@{#28174} TBR=jkummerow@chromium.org,yangguo@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/b0b82fa89d61603789b06c89d086427aae540b3f Cr-Commit-Position: refs/heads/master@{#28182}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+407 lines, -474 lines) Patch
M src/api.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/array.js View 9 chunks +10 lines, -10 lines 0 comments Download
M src/array-iterator.js View 1 chunk +3 lines, -3 lines 0 comments Download
M src/arraybuffer.js View 1 chunk +3 lines, -3 lines 0 comments Download
M src/bootstrapper.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/collection.js View 6 chunks +8 lines, -8 lines 0 comments Download
M src/collection-iterator.js View 2 chunks +6 lines, -6 lines 0 comments Download
M src/date.js View 2 chunks +2 lines, -2 lines 0 comments Download
M src/generator.js View 2 chunks +3 lines, -3 lines 0 comments Download
M src/harmony-array.js View 5 chunks +6 lines, -6 lines 0 comments Download
M src/harmony-array-includes.js View 1 chunk +1 line, -1 line 0 comments Download
M src/harmony-reflect.js View 1 chunk +1 line, -1 line 0 comments Download
M src/harmony-tostring.js View 1 chunk +1 line, -1 line 0 comments Download
M src/harmony-typedarray.js View 3 chunks +4 lines, -9 lines 0 comments Download
M src/i18n.js View 28 chunks +61 lines, -60 lines 0 comments Download
M src/isolate.h View 1 chunk +0 lines, -3 lines 0 comments Download
M src/isolate.cc View 3 chunks +26 lines, -27 lines 0 comments Download
M src/json.js View 4 chunks +4 lines, -4 lines 0 comments Download
M src/macros.py View 1 chunk +1 line, -1 line 0 comments Download
M src/math.js View 2 chunks +2 lines, -2 lines 0 comments Download
M src/messages.js View 12 chunks +15 lines, -23 lines 0 comments Download
M src/mirror-debugger.js View 1 chunk +1 line, -1 line 0 comments Download
M src/object-observe.js View 6 chunks +9 lines, -9 lines 0 comments Download
M src/promise.js View 2 chunks +2 lines, -2 lines 0 comments Download
M src/proxy.js View 2 chunks +2 lines, -2 lines 0 comments Download
M src/regexp.js View 1 chunk +1 line, -1 line 0 comments Download
M src/string.js View 1 chunk +2 lines, -2 lines 0 comments Download
M src/string-iterator.js View 1 chunk +3 lines, -3 lines 0 comments Download
M src/symbol.js View 4 chunks +5 lines, -5 lines 0 comments Download
M src/third_party/fdlibm/fdlibm.js View 1 chunk +1 line, -1 line 0 comments Download
M src/typedarray.js View 7 chunks +35 lines, -41 lines 0 comments Download
M src/uri.js View 1 chunk +1 line, -1 line 0 comments Download
M src/v8natives.js View 14 chunks +180 lines, -209 lines 0 comments Download
M src/weak-collection.js View 2 chunks +2 lines, -2 lines 0 comments Download
M test/mjsunit/compiler/jsnatives.js View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/jsmin.py View 7 chunks +1 line, -17 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Michael Achenbach
Created Revert of Wrap v8natives.js into a function.
5 years, 7 months ago (2015-04-30 17:31:24 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1121453003/1
5 years, 7 months ago (2015-04-30 17:32:10 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-04-30 17:33:19 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/b0b82fa89d61603789b06c89d086427aae540b3f Cr-Commit-Position: refs/heads/master@{#28182}
5 years, 7 months ago (2015-04-30 17:33:36 UTC) #4
Michael Achenbach
5 years, 7 months ago (2015-04-30 19:25:44 UTC) #5
Message was sent while issue was closed.
On 2015/04/30 17:33:36, I haz the power (commit-bot) wrote:
> Patchset 1 (id:??) landed as
> https://crrev.com/b0b82fa89d61603789b06c89d086427aae540b3f
> Cr-Commit-Position: refs/heads/master@{#28182}

This revert helped.

Powered by Google App Engine
This is Rietveld 408576698