Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(300)

Issue 1121433003: Fix mouse cursor update timer to be page-global instead of per-frame (Closed)

Created:
5 years, 7 months ago by Rick Byers
Modified:
5 years, 7 months ago
Reviewers:
bokan
CC:
blink-reviews, blink-reviews-rendering, zoltan1, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, blink-reviews-events_chromium.org, dglazkov+blink, jchaffraix+rendering
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Fix mouse cursor update timer to be page-global instead of per-frame When style changes in a way which could change the active mouse cursor, we start a timer to do a hit test and possibly update the active mouse cursor (without requiring the mouse to actually move). This was being done local to each frame which results in a number of problems in multi-frame scenarios (since a local hit test in one frame won't return the same results as that in another). This change moves the cursor selection logic (and the last cursor tracking we rely on for testing) to be global to a Page instead of per frame. BUG=482971 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=194825

Patch Set 1 #

Total comments: 6

Patch Set 2 : bokan cr feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+135 lines, -15 lines) Patch
A LayoutTests/fast/events/mouse-cursor-style-change-iframe.html View 1 1 chunk +83 lines, -0 lines 0 comments Download
A LayoutTests/fast/events/mouse-cursor-style-change-iframe-expected.txt View 1 chunk +23 lines, -0 lines 0 comments Download
M Source/core/layout/LayoutObject.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/page/Chrome.h View 2 chunks +2 lines, -0 lines 0 comments Download
M Source/core/page/Chrome.cpp View 1 chunk +6 lines, -0 lines 0 comments Download
M Source/core/page/EventHandler.h View 4 chunks +4 lines, -2 lines 0 comments Download
M Source/core/page/EventHandler.cpp View 6 chunks +15 lines, -11 lines 0 comments Download
M Source/core/testing/Internals.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
Rick Byers
Dave, please take a look. I'm fixing this so that I can reland the fix ...
5 years, 7 months ago (2015-04-30 16:44:42 UTC) #2
bokan
lgtm w/comments https://codereview.chromium.org/1121433003/diff/1/LayoutTests/fast/events/mouse-cursor-style-change-iframe.html File LayoutTests/fast/events/mouse-cursor-style-change-iframe.html (right): https://codereview.chromium.org/1121433003/diff/1/LayoutTests/fast/events/mouse-cursor-style-change-iframe.html#newcode20 LayoutTests/fast/events/mouse-cursor-style-change-iframe.html:20: <iframe id=frame srcdoc="<body style='height: 500px; cursor: text;'></body>"></iframe> ...
5 years, 7 months ago (2015-05-01 15:55:56 UTC) #3
Rick Byers
https://codereview.chromium.org/1121433003/diff/1/LayoutTests/fast/events/mouse-cursor-style-change-iframe.html File LayoutTests/fast/events/mouse-cursor-style-change-iframe.html (right): https://codereview.chromium.org/1121433003/diff/1/LayoutTests/fast/events/mouse-cursor-style-change-iframe.html#newcode20 LayoutTests/fast/events/mouse-cursor-style-change-iframe.html:20: <iframe id=frame srcdoc="<body style='height: 500px; cursor: text;'></body>"></iframe> On 2015/05/01 ...
5 years, 7 months ago (2015-05-01 17:26:47 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1121433003/20001
5 years, 7 months ago (2015-05-01 17:27:15 UTC) #7
commit-bot: I haz the power
5 years, 7 months ago (2015-05-01 19:02:51 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=194825

Powered by Google App Engine
This is Rietveld 408576698