Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Issue 1121433002: Always use a FunctionPassManager in pnacl-llc. MPPassManager breaks threading. (Closed)

Created:
5 years, 7 months ago by jvoung (off chromium)
Modified:
5 years, 7 months ago
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-llvm.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Always use a FunctionPassManager in pnacl-llc. MPPassManager breaks threading. Otherwise every thread will translate every function and we end up with duplicates. I.e., we cannot leave out -streaming-bitcode and translate with more than one thread (which is the default in pnacl-translate). The -streaming-bitcode flag still affects how the bitcode is read in however (everything materialized at once or lazily), so "createPNaClABIVerifyModulePass(&ABIErrorReporter, LazyBitcode)" is left alone. Ultimately, this is to help make it easy to temporarily leave off "-streaming-bitcode" until we find the source of non-determinism. Switching to FunctionPassManager does not affect the non-determinism either way (so the problem may be in the materialization or something else instead): BUG= https://code.google.com/p/nativeclient/issues/detail?id=4101 BUG= https://code.google.com/p/chromium/issues/detail?id=429358 R=phosek@chromium.org Committed: https://chromium.googlesource.com/native_client/pnacl-llvm/+/a8a2dc9a254ba1f10e65f117dc7f14a64cca6cff

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -50 lines) Patch
M tools/pnacl-llc/pnacl-llc.cpp View 2 chunks +43 lines, -50 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
jvoung (off chromium)
thoughts?
5 years, 7 months ago (2015-04-30 16:09:07 UTC) #2
Petr Hosek
lgtm
5 years, 7 months ago (2015-04-30 17:43:31 UTC) #3
jvoung (off chromium)
5 years, 7 months ago (2015-04-30 21:17:00 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
a8a2dc9a254ba1f10e65f117dc7f14a64cca6cff (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698