Cast:Moving netwrok sender related code to a designated folder

Cast:Moving netwrok sender related code to a designated folder

This cl is a first step in splitting up the cast library. At the end of this effort, the cast sender will be split into two: Generic protocol and encoding remain as is, all handling of coded frames to transmission will be in a designated folder (currently named net). 

This cl ONLY handles the moving of the files.
Future cl's will include:
 - New cast_net API
 - Adding RTCP handling
 - Designated target (and namespace)

BUG=327482
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=240166

[mikhal1, 2013-12-10 22:43:48]

Please review,
-Mikhal

[pwestin, 2013-12-10 23:03:00]

Some questions

https://chromiumcodereview.appspot.com/112133002/diff/1/media/cast/cast.gyp
File media/cast/cast.gyp (right):

https://chromiumcodereview.appspot.com/112133002/diff/1/media/cast/cast.gyp#n...
media/cast/cast.gyp:69: 'net/pacing/mock_paced_packet_sender.cc',
can you make all net/ to a lib? seems like you have gyp file already

https://chromiumcodereview.appspot.com/112133002/diff/1/media/cast/cast_sende...
File media/cast/cast_sender.gyp (right):

https://chromiumcodereview.appspot.com/112133002/diff/1/media/cast/cast_sende...
media/cast/cast_sender.gyp:29: 'net/cast_net.gyp:cast_net',
where is this gyp file?

https://chromiumcodereview.appspot.com/112133002/diff/1/media/cast/net/rtp_se...
File media/cast/net/rtp_sender/rtp_packetizer/test/rtp_header_parser.h (right):

https://chromiumcodereview.appspot.com/112133002/diff/1/media/cast/net/rtp_se...
media/cast/net/rtp_sender/rtp_packetizer/test/rtp_header_parser.h:15: struct
RtpCastTestHeader {
confused about this struct why do we need it?

https://chromiumcodereview.appspot.com/112133002/diff/1/media/cast/net/rtp_se...
media/cast/net/rtp_sender/rtp_packetizer/test/rtp_header_parser.h:60: private:
line break

[mikhal1, 2013-12-11 00:29:33]

PTAL

https://chromiumcodereview.appspot.com/112133002/diff/1/media/cast/cast.gyp
File media/cast/cast.gyp (right):

https://chromiumcodereview.appspot.com/112133002/diff/1/media/cast/cast.gyp#n...
media/cast/cast.gyp:69: 'net/pacing/mock_paced_packet_sender.cc',
On 2013/12/10 23:03:01, pwestin wrote:
> can you make all net/ to a lib? seems like you have gyp file already 
Removed the dependency, and keeping this cl just about moving files.

https://chromiumcodereview.appspot.com/112133002/diff/1/media/cast/cast_sende...
File media/cast/cast_sender.gyp (right):

https://chromiumcodereview.appspot.com/112133002/diff/1/media/cast/cast_sende...
media/cast/cast_sender.gyp:29: 'net/cast_net.gyp:cast_net',
Removed the dependency, and keeping this cl just about moving files.
On 2013/12/10 23:03:01, pwestin wrote:
> where is this gyp file?

https://chromiumcodereview.appspot.com/112133002/diff/1/media/cast/net/rtp_se...
File media/cast/net/rtp_sender/rtp_packetizer/test/rtp_header_parser.h (right):

https://chromiumcodereview.appspot.com/112133002/diff/1/media/cast/net/rtp_se...
media/cast/net/rtp_sender/rtp_packetizer/test/rtp_header_parser.h:15: struct
RtpCastTestHeader {
Just for testing. Before I was using the RtpCastHeader which includes Webrtc.
This is now moved to the rtp_receiver, and therefore not available here.
On 2013/12/10 23:03:01, pwestin wrote:
> confused about this struct why do we need it?

https://chromiumcodereview.appspot.com/112133002/diff/1/media/cast/net/rtp_se...
media/cast/net/rtp_sender/rtp_packetizer/test/rtp_header_parser.h:60: private:
On 2013/12/10 23:03:01, pwestin wrote:
> line break

Done.

[pwestin, 2013-12-11 01:24:27]

please remove duplicates in the gyp file

https://chromiumcodereview.appspot.com/112133002/diff/20001/media/cast/cast.gyp
File media/cast/cast.gyp (right):

https://chromiumcodereview.appspot.com/112133002/diff/20001/media/cast/cast.g...
media/cast/cast.gyp:97: 'net/pacing/paced_sender_unittest.cc',
these duplicates keep coming back... please dont add

[mikhal1, 2013-12-11 16:14:12]

PTAL

https://chromiumcodereview.appspot.com/112133002/diff/20001/media/cast/cast.gyp
File media/cast/cast.gyp (right):

https://chromiumcodereview.appspot.com/112133002/diff/20001/media/cast/cast.g...
media/cast/cast.gyp:97: 'net/pacing/paced_sender_unittest.cc',
On 2013/12/11 01:24:28, pwestin wrote:
> these duplicates keep coming back... please dont add 

Done.

[pwestin, 2013-12-11 16:15:19]

lgtm

[commit-bot: I haz the power, 2013-12-11 16:15:32]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mikhal@chromium.org/112133002/40001

[commit-bot: I haz the power, 2013-12-11 17:16:02]

Retried try job too often on linux_chromeos_clang for step(s) compile
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chro...

[commit-bot: I haz the power, 2013-12-11 18:12:13]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mikhal@chromium.org/112133002/60001

[commit-bot: I haz the power, 2013-12-11 20:23:50]

Change committed as 240166