Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(533)

Issue 1121233010: [chrome/browser/chromeos/login] Replace MessageLoopProxy usage with ThreadTaskRunnerHandle (Closed)

Created:
5 years, 7 months ago by Pranay
Modified:
5 years, 7 months ago
Reviewers:
piman
CC:
chromium-reviews, dzhioev+watch_chromium.org, stevenjb+watch_chromium.org, oshima+watch_chromium.org, davemoore+watch_chromium.org, anujsharma
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Replace MessageLoopProxy usage with ThreadTaskRunnerHandle in chrome/browser/chromeos/login module. MessageLoopProxy is deprecated. This basically does a search and replace of: MessageLoopProxy::current() -> ThreadTaskRunnerHandle::Get(). MessageLoopProxy -> SingleThreadTaskRunner BUG=391045 Committed: https://crrev.com/9b50d88e85bf17a978857d307783ef31adad55be Cr-Commit-Position: refs/heads/master@{#328479}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -25 lines) Patch
M chrome/browser/chromeos/login/auth/online_attempt_unittest.cc View 4 chunks +17 lines, -17 lines 0 comments Download
M chrome/browser/chromeos/login/screens/user_image_screen.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/login/session/user_session_manager.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/users/avatar/user_image_loader.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/users/avatar/user_image_manager_impl.cc View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
Pranay
PTAL Thanks
5 years, 7 months ago (2015-05-05 06:29:09 UTC) #2
piman
lgtm
5 years, 7 months ago (2015-05-05 17:54:28 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1121233010/1
5 years, 7 months ago (2015-05-06 02:42:20 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-06 03:10:32 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-05-06 03:11:34 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9b50d88e85bf17a978857d307783ef31adad55be
Cr-Commit-Position: refs/heads/master@{#328479}

Powered by Google App Engine
This is Rietveld 408576698