[chrome/browser/net] Replace MessageLoopProxy usage with ThreadTaskRunnerHandle

Replace MessageLoopProxy usage with ThreadTaskRunnerHandle in chrome browser net module.

MessageLoopProxy is deprecated.
This basically does a search and replace:

MessageLoopProxy::current() -> ThreadTaskRunnerHandle::Get().

BUG=391045
Committed: https://crrev.com/cb29b0e262bd5d63a1d550ca5333457f68bf1c72
Cr-Commit-Position: refs/heads/master@{#328483}

[Pranay, 2015-05-04 07:34:42]

pranay.kumar@samsung.com changed reviewers:
+ rsleevi@chromium.org

[Pranay, 2015-05-04 07:34:43]

PTAL,

Thanks

[Ryan Sleevi, 2015-05-04 18:11:27]

https://codereview.chromium.org/1121213002/diff/1/chrome/browser/net/nss_cont...
File chrome/browser/net/nss_context.cc (right):

https://codereview.chromium.org/1121213002/diff/1/chrome/browser/net/nss_cont...
chrome/browser/net/nss_context.cc:19:
scoped_refptr<base::SingleThreadTaskRunner> response_task_runner,
This should be passed as a SequencedTaskRunner and const-ref

https://codereview.chromium.org/1121213002/diff/1/chrome/browser/net/nss_cont...
chrome/browser/net/nss_context.cc:30:
scoped_refptr<base::SingleThreadTaskRunner> response_task_runner,
This should be a const-ref SequencedTaskRunner

https://codereview.chromium.org/1121213002/diff/1/chrome/browser/net/quota_po...
File chrome/browser/net/quota_policy_channel_id_store_unittest.cc (right):

https://codereview.chromium.org/1121213002/diff/1/chrome/browser/net/quota_po...
chrome/browser/net/quota_policy_channel_id_store_unittest.cc:117:
base::ThreadTaskRunnerHandle::Get(),
IWYU: If you're going to change  this, you need to include
single_thread_task_runner.h so that the TTRH::Get() call (which returns a
scoped_refptr<SingleThreadTaskRunner>) can be convertible to a
SequencedTaskRunner that QuotaPolicyChannelIDStore expects.

I think you're indirectly relying on #includes to sort that out, but it's wrong
- include what you use.

https://codereview.chromium.org/1121213002/diff/1/chrome/browser/net/utility_...
File chrome/browser/net/utility_process_mojo_proxy_resolver_factory.cc (right):

https://codereview.chromium.org/1121213002/diff/1/chrome/browser/net/utility_...
chrome/browser/net/utility_process_mojo_proxy_resolver_factory.cc:41:
base::ThreadTaskRunnerHandle::Get().get());
IWYU: Same issue - you include to include STTR's header to ensure that
TTRH::Get() is converted to an STR

Also, the extra .get() seems wrong and relying on implicit up-conversion from a
naked pointer back to a scoped_refptr<> temporary

base::ThreadTaskRunnerHandle::Get() should be sufficient.

[Pranay, 2015-05-05 04:18:38]

https://codereview.chromium.org/1121213002/diff/1/chrome/browser/net/nss_cont...
File chrome/browser/net/nss_context.cc (right):

https://codereview.chromium.org/1121213002/diff/1/chrome/browser/net/nss_cont...
chrome/browser/net/nss_context.cc:19:
scoped_refptr<base::SingleThreadTaskRunner> response_task_runner,
On 2015/05/04 18:11:27, Ryan Sleevi wrote:
> This should be passed as a SequencedTaskRunner and const-ref

Done.

https://codereview.chromium.org/1121213002/diff/1/chrome/browser/net/nss_cont...
chrome/browser/net/nss_context.cc:30:
scoped_refptr<base::SingleThreadTaskRunner> response_task_runner,
On 2015/05/04 18:11:27, Ryan Sleevi wrote:
> This should be a const-ref SequencedTaskRunner

Done.

https://codereview.chromium.org/1121213002/diff/1/chrome/browser/net/quota_po...
File chrome/browser/net/quota_policy_channel_id_store_unittest.cc (right):

https://codereview.chromium.org/1121213002/diff/1/chrome/browser/net/quota_po...
chrome/browser/net/quota_policy_channel_id_store_unittest.cc:117:
base::ThreadTaskRunnerHandle::Get(),
On 2015/05/04 18:11:27, Ryan Sleevi wrote:
> IWYU: If you're going to change  this, you need to include
> single_thread_task_runner.h so that the TTRH::Get() call (which returns a
> scoped_refptr<SingleThreadTaskRunner>) can be convertible to a
> SequencedTaskRunner that QuotaPolicyChannelIDStore expects.
> 
> I think you're indirectly relying on #includes to sort that out, but it's
wrong
> - include what you use.

Done.

https://codereview.chromium.org/1121213002/diff/1/chrome/browser/net/utility_...
File chrome/browser/net/utility_process_mojo_proxy_resolver_factory.cc (right):

https://codereview.chromium.org/1121213002/diff/1/chrome/browser/net/utility_...
chrome/browser/net/utility_process_mojo_proxy_resolver_factory.cc:41:
base::ThreadTaskRunnerHandle::Get().get());
On 2015/05/04 18:11:27, Ryan Sleevi wrote:
> IWYU: Same issue - you include to include STTR's header to ensure that
> TTRH::Get() is converted to an STR
> 
> Also, the extra .get() seems wrong and relying on implicit up-conversion from
a
> naked pointer back to a scoped_refptr<> temporary
> 
> base::ThreadTaskRunnerHandle::Get() should be sufficient.

Done.

[Pranay, 2015-05-05 04:19:38]

Hi, 
Thanks for the review. I've uploaded the updated patch.

PTAL

[Ryan Sleevi, 2015-05-05 23:58:37]

lgtm

[Pranay, 2015-05-06 02:43:16]

The CQ bit was checked by pranay.kumar@samsung.com

[commit-bot: I haz the power, 2015-05-06 02:43:35]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1121213002/20001

[commit-bot: I haz the power, 2015-05-06 03:56:38]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-05-06 03:57:41]

Patchset 2 (id:??) landed as
https://crrev.com/cb29b0e262bd5d63a1d550ca5333457f68bf1c72
Cr-Commit-Position: refs/heads/master@{#328483}