Source/core/layout/LayoutBox.h - Issue 1121173002: Fix shrink-to-fit when children's writing-mode is orthogonal

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/layout/LayoutBox.h

Issue 1121173002: Fix shrink-to-fit when children's writing-mode is orthogonal (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Tests and test results updated Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/layout/LayoutBox.h

diff --git a/Source/core/layout/LayoutBox.h b/Source/core/layout/LayoutBox.h

index 4b5eb321afd1264735263c1ac17fe70d0e8b052c..b4bb80cf4b93dc0799f1f243cc223c7da1a5c42d 100644

--- a/Source/core/layout/LayoutBox.h

+++ b/Source/core/layout/LayoutBox.h

@@ -599,6 +599,7 @@ public:

virtual void markForPaginationRelayoutIfNeeded(SubtreeLayoutScope&);

bool isWritingModeRoot() const { return !parent() || parent()->style()->writingMode() != style()->writingMode(); }

+ bool isWritingModeOrthogonalToParent() const { return parent() && parent()->isHorizontalWritingMode() != isHorizontalWritingMode(); }

bool isDeprecatedFlexItem() const { return !isInline() && !isFloatingOrOutOfFlowPositioned() && parent() && parent()->isDeprecatedFlexibleBox(); }

bool isFlexItemIncludingDeprecated() const { return !isInline() && !isFloatingOrOutOfFlowPositioned() && parent() && parent()->isFlexibleBoxIncludingDeprecated(); }

« no previous file with comments | « Source/core/layout/LayoutBlockFlowLine.cpp ('k') | Source/core/layout/LayoutObject.h » ('j') | Source/core/layout/LayoutObject.cpp » ('J')