Issue 112103012: Update default shape property value to 'none'

Issue 112103012: Update default shape property value to 'none' (Closed)

Created:
6 years, 11 months ago by Bear Travis

Modified:
6 years, 11 months ago

Reviewers:
esprehn

CC:
blink-reviews, dglazkov+blink, apavlov+blink_chromium.org, darktears

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Update default shape property value to 'none' The default value of the shape-inside and shape-outside properties has changed from 'auto' to 'none'. This patch changes the CSS parsing code and fixes up the tests. BUG=322165 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=165016

Patch Set 1 #

Patch Set 2 : Fixing interpolation tests #

Patch Set 3 : Merging with new ellipse code #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+214 lines, -214 lines)			Patch
M	LayoutTests/animations/interpolation/shape-inside.html	View	1	1 chunk	+4 lines, -4 lines	0 comments	Download
M	LayoutTests/animations/interpolation/shape-inside-expected.txt	View	1	1 chunk	+6 lines, -6 lines	0 comments	Download
M	LayoutTests/animations/interpolation/shape-outside.html	View	1 2	1 chunk	+4 lines, -4 lines	0 comments	Download
M	LayoutTests/animations/interpolation/shape-outside-expected.txt	View	1 2	1 chunk	+6 lines, -6 lines	0 comments	Download
M	LayoutTests/fast/shapes/parsing/parsing-shape-inside.html	View		1 chunk	+6 lines, -6 lines	0 comments	Download
M	LayoutTests/fast/shapes/parsing/parsing-shape-inside-expected.txt	View	1 2	2 chunks	+68 lines, -68 lines	0 comments	Download
M	LayoutTests/fast/shapes/parsing/parsing-shape-lengths.html	View		1 chunk	+1 line, -1 line	0 comments	Download
M	LayoutTests/fast/shapes/parsing/parsing-shape-lengths-expected.txt	View		1 chunk	+17 lines, -17 lines	0 comments	Download
M	LayoutTests/fast/shapes/parsing/parsing-shape-margin-expected.txt	View		1 chunk	+1 line, -1 line	0 comments	Download
M	LayoutTests/fast/shapes/parsing/parsing-shape-outside.html	View		1 chunk	+7 lines, -7 lines	0 comments	Download
M	LayoutTests/fast/shapes/parsing/parsing-shape-outside-expected.txt	View	1 2	2 chunks	+69 lines, -69 lines	0 comments	Download
M	LayoutTests/fast/shapes/parsing/parsing-shape-padding-expected.txt	View		1 chunk	+1 line, -1 line	0 comments	Download
M	LayoutTests/fast/shapes/parsing/parsing-test-utils.js	View	1 2	4 chunks	+9 lines, -9 lines	0 comments	Download
M	LayoutTests/virtual/legacy-animations-engine/animations/interpolation/shape-inside-expected.txt	View	1	1 chunk	+6 lines, -6 lines	0 comments	Download
M	LayoutTests/virtual/legacy-animations-engine/animations/interpolation/shape-outside-expected.txt	View	1 2	1 chunk	+6 lines, -6 lines	0 comments	Download
M	Source/core/css/CSSComputedStyleDeclaration.cpp	View	1 2	2 chunks	+2 lines, -2 lines	0 comments	Download
M	Source/core/css/parser/BisonCSSParser-in.cpp	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/betravis@adobe.com/112103012/30001

6 years, 11 months ago (2014-01-13 19:54:58 UTC) #2

commit-bot: I haz the power

Failed to apply patch for LayoutTests/animations/interpolation/shape-outside-expected.txt: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...

6 years, 11 months ago (2014-01-13 19:55:09 UTC) #3

Failed to apply patch for
LayoutTests/animations/interpolation/shape-outside-expected.txt:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file LayoutTests/animations/interpolation/shape-outside-expected.txt
  Hunk #1 FAILED at 28.
  1 out of 1 hunk FAILED -- saving rejects to file
LayoutTests/animations/interpolation/shape-outside-expected.txt.rej

Patch:       LayoutTests/animations/interpolation/shape-outside-expected.txt
Index: LayoutTests/animations/interpolation/shape-outside-expected.txt
diff --git a/LayoutTests/animations/interpolation/shape-outside-expected.txt
b/LayoutTests/animations/interpolation/shape-outside-expected.txt
index
5998c27ccbbe388cdda43097b14214041f2a9461..47f1234de922aa5daa486a4e757552a883391f93
100644
--- a/LayoutTests/animations/interpolation/shape-outside-expected.txt
+++ b/LayoutTests/animations/interpolation/shape-outside-expected.txt
@@ -28,10 +28,10 @@ PASS: shape-outside from [polygon(nonzero, 0px 0px, 25px
25px, 50px 50px)] to [p
 PASS: shape-outside from [polygon(nonzero, 0px 0px, 25px 25px, 50px 50px)] to
[polygon(nonzero, 25px 25px, 50px 50px, 75px 75px)] was [polygon(nonzero, 15px
15px, 40px 40px, 65px 65px)] at 0.6
 PASS: shape-outside from [polygon(nonzero, 0px 0px, 25px 25px, 50px 50px)] to
[polygon(nonzero, 25px 25px, 50px 50px, 75px 75px)] was [polygon(nonzero, 25px
25px, 50px 50px, 75px 75px)] at 1
 PASS: shape-outside from [polygon(nonzero, 0px 0px, 25px 25px, 50px 50px)] to
[polygon(nonzero, 25px 25px, 50px 50px, 75px 75px)] was [polygon(nonzero, 37.5px
37.5px, 62.5px 62.5px, 87.5px 87.5px)] at 1.5
-PASS: shape-outside from [auto] to [ellipse(0%, 0%, 100%, 100%)] was [auto] at
-0.3
-PASS: shape-outside from [auto] to [ellipse(0%, 0%, 100%, 100%)] was [auto] at
0
-PASS: shape-outside from [auto] to [ellipse(0%, 0%, 100%, 100%)] was [auto] at
0.3
-PASS: shape-outside from [auto] to [ellipse(0%, 0%, 100%, 100%)] was
[ellipse(0%, 0%, 100%, 100%)] at 0.6
-PASS: shape-outside from [auto] to [ellipse(0%, 0%, 100%, 100%)] was
[ellipse(0%, 0%, 100%, 100%)] at 1
-PASS: shape-outside from [auto] to [ellipse(0%, 0%, 100%, 100%)] was
[ellipse(0%, 0%, 100%, 100%)] at 1.5
+PASS: shape-outside from [none] to [ellipse(0%, 0%, 100%, 100%)] was [none] at
-0.3
+PASS: shape-outside from [none] to [ellipse(0%, 0%, 100%, 100%)] was [none] at
0
+PASS: shape-outside from [none] to [ellipse(0%, 0%, 100%, 100%)] was [none] at
0.3
+PASS: shape-outside from [none] to [ellipse(0%, 0%, 100%, 100%)] was
[ellipse(0%, 0%, 100%, 100%)] at 0.6
+PASS: shape-outside from [none] to [ellipse(0%, 0%, 100%, 100%)] was
[ellipse(0%, 0%, 100%, 100%)] at 1
+PASS: shape-outside from [none] to [ellipse(0%, 0%, 100%, 100%)] was
[ellipse(0%, 0%, 100%, 100%)] at 1.5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/betravis@adobe.com/112103012/100001

6 years, 11 months ago (2014-01-14 00:04:47 UTC) #4

Message was sent while issue was closed.

Change committed as 165016

Expand Messages | Collapse Messages