Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(682)

Issue 1121003003: [GCM] Adding handling of heartbeat intervals to the GCM store. (Closed)

Created:
5 years, 7 months ago by fgorski
Modified:
5 years, 7 months ago
CC:
chromium-reviews, zea+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@heartbeat-gcm
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Adding handling of heartbeat intervals to the GCM store. Adding methods to GCMStore, GCMStoreImpl and ::Backend: * AddHeartbeatInterval, RemoveHeartbeatInterval, for managing persistence, as well as * LoadHeartbeatIntervals to load intervals at startup Adding tests for the above. BUG=481174 Committed: https://crrev.com/06a32f524691c4efc432d4df1736d69c24360c75 Cr-Commit-Position: refs/heads/master@{#328191}

Patch Set 1 #

Patch Set 2 : Adding histrograms #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+183 lines, -1 line) Patch
M google_apis/gcm/engine/gcm_store.h View 2 chunks +8 lines, -0 lines 0 comments Download
M google_apis/gcm/engine/gcm_store_impl.h View 1 chunk +7 lines, -0 lines 0 comments Download
M google_apis/gcm/engine/gcm_store_impl.cc View 9 chunks +116 lines, -1 line 2 comments Download
M google_apis/gcm/engine/gcm_store_impl_unittest.cc View 1 chunk +51 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
fgorski
Nicolas, PTAL. This is patch 2. I'll wire everything up in the next one.
5 years, 7 months ago (2015-05-01 21:35:39 UTC) #2
Nicolas Zea
LGTM https://codereview.chromium.org/1121003003/diff/20001/google_apis/gcm/engine/gcm_store_impl.cc File google_apis/gcm/engine/gcm_store_impl.cc (right): https://codereview.chromium.org/1121003003/diff/20001/google_apis/gcm/engine/gcm_store_impl.cc#newcode147 google_apis/gcm/engine/gcm_store_impl.cc:147: std::string MakeHeartbeatKey(const std::string& scope) { remind me, what ...
5 years, 7 months ago (2015-05-04 17:45:28 UTC) #3
fgorski
Starting tests, adding Alexei for histograms. https://codereview.chromium.org/1121003003/diff/20001/google_apis/gcm/engine/gcm_store_impl.cc File google_apis/gcm/engine/gcm_store_impl.cc (right): https://codereview.chromium.org/1121003003/diff/20001/google_apis/gcm/engine/gcm_store_impl.cc#newcode147 google_apis/gcm/engine/gcm_store_impl.cc:147: std::string MakeHeartbeatKey(const std::string& ...
5 years, 7 months ago (2015-05-04 18:14:54 UTC) #5
Alexei Svitkine (slow)
lgtm
5 years, 7 months ago (2015-05-04 18:29:41 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1121003003/20001
5 years, 7 months ago (2015-05-04 19:02:38 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-05-04 21:40:57 UTC) #9
commit-bot: I haz the power
5 years, 7 months ago (2015-05-04 21:42:02 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/06a32f524691c4efc432d4df1736d69c24360c75
Cr-Commit-Position: refs/heads/master@{#328191}

Powered by Google App Engine
This is Rietveld 408576698