Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(370)

Unified Diff: pkg/analyzer/lib/src/context/context.dart

Issue 1120973003: Finish AnalysisContext.getLaunchableServerLibrarySources implementation. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pkg/analyzer/test/src/context/context_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analyzer/lib/src/context/context.dart
diff --git a/pkg/analyzer/lib/src/context/context.dart b/pkg/analyzer/lib/src/context/context.dart
index b8158c2410541dbf17867ca6aef40184a778694d..8bf4c88d05af4bab6afcf049892e438166fceda0 100644
--- a/pkg/analyzer/lib/src/context/context.dart
+++ b/pkg/analyzer/lib/src/context/context.dart
@@ -276,8 +276,6 @@ class AnalysisContextImpl implements InternalAnalysisContext {
@override
List<Source> get launchableServerLibrarySources {
- // TODO(brianwilkerson) This needs to filter out libraries that reference
- // dart:html, either directly or indirectly.
List<Source> sources = new List<Source>();
MapIterator<AnalysisTarget, cache.CacheEntry> iterator = _cache.iterator();
while (iterator.moveNext()) {
@@ -285,11 +283,9 @@ class AnalysisContextImpl implements InternalAnalysisContext {
cache.CacheEntry entry = iterator.value;
if (target is Source &&
entry.getValue(SOURCE_KIND) == SourceKind.LIBRARY &&
- !target.isInSystemLibrary) {
-// DartEntry dartEntry = (DartEntry) sourceEntry;
-// if (dartEntry.getValue(DartEntry.IS_LAUNCHABLE) && !dartEntry.getValue(DartEntry.IS_CLIENT)) {
+ !target.isInSystemLibrary &&
+ isServerLibrary(target)) {
sources.add(target);
-// }
}
}
return sources;
« no previous file with comments | « no previous file | pkg/analyzer/test/src/context/context_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698