Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(155)

Issue 1120963002: Revert of plugins/update-widgets-crash.html victim element goes missing (Closed)

Created:
5 years ago by Noel Gordon
Modified:
5 years ago
Reviewers:
haraken, bbudge
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Revert of plugins/update-widgets-crash.html victim element goes missing (patchset #1 id:1 of https://codereview.chromium.org/1122483002/) Reason for revert: Didn't quite fix the issue: same failure appeared on the build bots. Reverting here to fix via TestExpectations instead. Original issue's description: > plugins/update-widgets-crash.html victim element goes missing > > The victim element to be removed is non-existant sometimes after the bugs > listed resolved. Workaround for now, by testing that the "victim" element > exists to avoid an exception, which causes extra test console output, and > fails the test. See issue 476590 #46 for a bot failure example. > > TBR=haraken@chromium.org > BUG=457054, 476590 > NOTRY=true > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=194807 TBR=haraken@chromium.org,bbudge@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=457054, 476590 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=194809

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M LayoutTests/plugins/update-widgets-crash.html View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Noel Gordon
Created Revert of plugins/update-widgets-crash.html victim element goes missing
5 years ago (2015-05-01 15:21:03 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1120963002/1
5 years ago (2015-05-01 15:21:10 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://src.chromium.org/viewvc/blink?view=rev&revision=194809
5 years ago (2015-05-01 15:21:39 UTC) #3
haraken
5 years ago (2015-05-01 15:28:17 UTC) #4
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698