Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1708)

Unified Diff: Source/platform/heap/ThreadState.cpp

Issue 1120943002: Various ASan exemptions to allow Oilpan pre-sweep poisoning of unmarkeds. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: add custom NO_SANITIZE_ADDRESS variation Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/platform/heap/ThreadState.cpp
diff --git a/Source/platform/heap/ThreadState.cpp b/Source/platform/heap/ThreadState.cpp
index 699866a4516830374b32646ac8351c86a8c97e33..578e2564ea46b0dd0ffac86edde728d5a3fdf850 100644
--- a/Source/platform/heap/ThreadState.cpp
+++ b/Source/platform/heap/ThreadState.cpp
@@ -898,11 +898,9 @@ void ThreadState::preSweep()
// TODO(haraken): Currently we cannot enable the poisoning because we have
// real bugs where destructors touch other on-heap objects. Remove all the bugs
// and enable the poisoning.
-#if 0
for (int i = 0; i < NumberOfHeaps; i++)
m_heaps[i]->poisonUnmarkedObjects();
#endif
-#endif
#if ENABLE(OILPAN)
if (gcState() == EagerSweepScheduled) {

Powered by Google App Engine
This is Rietveld 408576698