Source/platform/heap/Handle.h - Issue 1120943002: Various ASan exemptions to allow Oilpan pre-sweep poisoning of unmarkeds.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/platform/heap/Handle.h

Issue 1120943002: Various ASan exemptions to allow Oilpan pre-sweep poisoning of unmarkeds. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/platform/heap/Handle.h

diff --git a/Source/platform/heap/Handle.h b/Source/platform/heap/Handle.h

index 8c16b932be93d88698866d0dff4ef01039ebea4c..2e193f99728613d09dbbb5812e51e25425b4ba51 100644

--- a/Source/platform/heap/Handle.h

+++ b/Source/platform/heap/Handle.h

@@ -53,6 +53,7 @@ public:

{

}

+ NO_SANITIZE_ADDRESS

haraken 2015/05/01 15:12:32 This looks valid.

bool isHeapObjectAlive() { return m_trace; }

virtual ~PersistentNode()

@@ -124,6 +125,7 @@ public:

template<typename RootsAccessor, typename Owner>

class PersistentBase : public PersistentNode {

public:

+ NO_SANITIZE_ADDRESS

haraken 2015/05/01 15:12:31 This looks valid.

~PersistentBase()

{

typename RootsAccessor::Lock lock;

« no previous file with comments | « Source/platform/Timer.cpp ('k') | Source/platform/heap/ThreadState.cpp » ('j') | Source/wtf/LinkedHashSet.h » ('J')