pkg/analysis_server/lib/src/services/completion/local_declaration_visitor.dart - Issue 1120893002: cleanup visitInheritedTypes signature

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analysis_server/lib/src/services/completion/local_declaration_visitor.dart

Issue 1120893002: cleanup visitInheritedTypes signature (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: update comments Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « pkg/analysis_server/lib/src/services/completion/imported_reference_contributor.dart ('k') | pkg/analysis_server/lib/src/services/completion/suggestion_builder.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/analysis_server/lib/src/services/completion/local_declaration_visitor.dart

diff --git a/pkg/analysis_server/lib/src/services/completion/local_declaration_visitor.dart b/pkg/analysis_server/lib/src/services/completion/local_declaration_visitor.dart

index d00921ae87aefbd9d4d10b83a0079f2867315078..6ba0afa8c4440fe019931f7b9761aa369236de90 100644

--- a/pkg/analysis_server/lib/src/services/completion/local_declaration_visitor.dart

+++ b/pkg/analysis_server/lib/src/services/completion/local_declaration_visitor.dart

@@ -110,10 +110,9 @@ abstract class LocalDeclarationVisitor extends GeneralizingAstVisitor {

@override

void visitClassDeclaration(ClassDeclaration node) {

_visitClassDeclarationMembers(node);

- visitInheritedTypes(node, (ClassDeclaration classNode) {

+ // imported types are handled by the imported reference contributor

+ visitInheritedTypes(node, localDeclaration: (ClassDeclaration classNode) {

_visitClassDeclarationMembers(classNode);

- }, (String typeName) {

- // ignored

});

visitNode(node);

}