cleanup visitInheritedTypes signature

pkg/analysis_server/lib/src/services/completion/suggestion_builder.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library services.completion.suggestion.builder;
 
 import 'dart:async';
 import 'dart:collection';
 
 import 'package:analysis_server/src/protocol_server.dart' as protocol;
@@ skipping 139 matching lines @@
       mixinTypes.forEach((TypeName type) {
         visit(type);
       });
     }
   }
 }
 
 /**
  * Starting with the given class node, traverse the inheritence hierarchy
  * calling the given functions with each non-null non-empty inherited class
- * declaration. For each locally defined class declaration, call [local].
+ * declaration. For each locally defined declaration, call [localDeclaration].
  * For each class identifier in the hierarchy that is not defined locally,
- * call the [imported] function.
+ * call the [importedTypeName] function.
  */
 void visitInheritedTypes(ClassDeclaration node,
-    void local(ClassDeclaration classNode), void imported(String typeName)) {
+    {void localDeclaration(ClassDeclaration classNode),
+    void importedTypeName(String typeName)}) {
   CompilationUnit unit = node.getAncestor((p) => p is CompilationUnit);
   List<ClassDeclaration> todo = new List<ClassDeclaration>();
   todo.add(node);
   Set<String> visited = new Set<String>();
   while (todo.length > 0) {
     node = todo.removeLast();
     visitInheritedTypeNames(node, (String name) {
       if (visited.add(name)) {
         var classNode = unit.declarations.firstWhere((member) {
           if (member is ClassDeclaration) {
             SimpleIdentifier id = member.name;
             if (id != null && id.name == name) {
               return true;
             }
           }
           return false;
         }, orElse: () => null);
         if (classNode is ClassDeclaration) {
-          local(classNode);
+          if (localDeclaration != null) {
+            localDeclaration(classNode);
+          }
           todo.add(classNode);
         } else {
-          imported(name);
+          if (importedTypeName != null) {
+            importedTypeName(name);
+          }
         }
       }
     });
   }
 }
 
 /**
  * Common mixin for sharing behavior
  */
 abstract class ElementSuggestionBuilder {
@@ skipping 412 matching lines @@
    * or `false` if [computeFull] should be called.
    */
   bool computeFast(AstNode node);
 
   /**
    * Return a future that computes the suggestions given a fully resolved AST.
    * The future returns `true` if suggestions were added, else `false`.
    */
   Future<bool> computeFull(AstNode node);
 }