Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(14)

Issue 1120833003: Put LayoutAnalyzer back behind disabled-by-default-blink.debug.layout. (Closed)

Created:
5 years ago by benjhayden
Modified:
5 years ago
Reviewers:
esprehn
CC:
blink-reviews, blink-reviews-rendering, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Put LayoutAnalyzer back behind disabled-by-default-blink.debug.layout. Another CL will remove the UMA. When the deep reports category is ready, this will move over to that. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=194781

Patch Set 1 #

Total comments: 6

Patch Set 2 : comments #

Patch Set 3 : m_analyzer #

Patch Set 4 : thinger #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -11 lines) Patch
M Source/core/frame/FrameView.h View 3 chunks +3 lines, -2 lines 0 comments Download
M Source/core/frame/FrameView.cpp View 1 2 4 chunks +21 lines, -4 lines 0 comments Download
M Source/core/layout/LayoutAnalyzer.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/layout/LayoutAnalyzer.cpp View 1 chunk +4 lines, -2 lines 0 comments Download
M Source/core/layout/LayoutBlock.cpp View 1 1 chunk +2 lines, -1 line 0 comments Download
M Source/core/layout/LayoutBlockFlow.cpp View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
benjhayden
5 years ago (2015-04-30 22:50:40 UTC) #2
esprehn
lgtm, we usually do if (Type* thing = thinger() and then thing->... under it. but ...
5 years ago (2015-04-30 23:32:35 UTC) #3
benjhayden
https://codereview.chromium.org/1120833003/diff/1/Source/core/frame/FrameView.cpp File Source/core/frame/FrameView.cpp (right): https://codereview.chromium.org/1120833003/diff/1/Source/core/frame/FrameView.cpp#newcode823 Source/core/frame/FrameView.cpp:823: if (!m_analyzer.get()) On 2015/04/30 at 23:32:35, esprehn wrote: > ...
5 years ago (2015-04-30 23:55:33 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1120833003/60001
5 years ago (2015-04-30 23:56:29 UTC) #7
commit-bot: I haz the power
Committed patchset #4 (id:60001) as https://src.chromium.org/viewvc/blink?view=rev&revision=194781
5 years ago (2015-05-01 01:22:53 UTC) #8
Noel Gordon
5 years ago (2015-05-01 08:10:17 UTC) #9
Message was sent while issue was closed.
A revert of this CL (patchset #4 id:60001) has been created in
https://codereview.chromium.org/1122453002/ by noel@chromium.org.

The reason for reverting is: crbug.com/483390  Looks like this change may have
caused the test on that bug to fail on all bots.  A speculative revert might
help resolve that.  Will roll back in otherwise..

Powered by Google App Engine
This is Rietveld 408576698