Put LayoutAnalyzer back behind disabled-by-default-blink.debug.layout.

Put LayoutAnalyzer back behind disabled-by-default-blink.debug.layout.

Another CL will remove the UMA.

When the deep reports category is ready, this will move over to that.

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=194781

[benjhayden, 2015-04-30 22:50:39]

benjhayden@chromium.org changed reviewers:
+ esprehn@chromium.org

[esprehn, 2015-04-30 23:32:35]

lgtm, we usually do if (Type* thing = thinger() and then thing->... under it.
but that doesn't matter much here. You can leave it either way.

https://codereview.chromium.org/1120833003/diff/1/Source/core/frame/FrameView...
File Source/core/frame/FrameView.cpp (right):

https://codereview.chromium.org/1120833003/diff/1/Source/core/frame/FrameView...
Source/core/frame/FrameView.cpp:823: if (!m_analyzer.get())
You don't need to call get(), you can just test it with !. OwnPtr is convertable
to a bool.

https://codereview.chromium.org/1120833003/diff/1/Source/core/frame/FrameView...
Source/core/frame/FrameView.cpp:860: if (layoutAnalyzer())
if (LayoutAnalyzer* analyzer = layoutAnalyzer())
  analyzer->...()

is the usual pattern for this kind of thing. Since this is a simple getter it's
not as important though.

https://codereview.chromium.org/1120833003/diff/1/Source/core/layout/LayoutBl...
File Source/core/layout/LayoutBlock.cpp (right):

https://codereview.chromium.org/1120833003/diff/1/Source/core/layout/LayoutBl...
Source/core/layout/LayoutBlock.cpp:1627: if (frameView()->layoutAnalyzer())
ditto.

[benjhayden, 2015-04-30 23:55:33]

https://codereview.chromium.org/1120833003/diff/1/Source/core/frame/FrameView...
File Source/core/frame/FrameView.cpp (right):

https://codereview.chromium.org/1120833003/diff/1/Source/core/frame/FrameView...
Source/core/frame/FrameView.cpp:823: if (!m_analyzer.get())
On 2015/04/30 at 23:32:35, esprehn wrote:
> You don't need to call get(), you can just test it with !. OwnPtr is
convertable to a bool.

Done.

https://codereview.chromium.org/1120833003/diff/1/Source/core/frame/FrameView...
Source/core/frame/FrameView.cpp:860: if (layoutAnalyzer())
On 2015/04/30 at 23:32:35, esprehn wrote:
> if (LayoutAnalyzer* analyzer = layoutAnalyzer())
>   analyzer->...()
> 
> is the usual pattern for this kind of thing. Since this is a simple getter
it's not as important though.

Changed to m_analyzer.

https://codereview.chromium.org/1120833003/diff/1/Source/core/layout/LayoutBl...
File Source/core/layout/LayoutBlock.cpp (right):

https://codereview.chromium.org/1120833003/diff/1/Source/core/layout/LayoutBl...
Source/core/layout/LayoutBlock.cpp:1627: if (frameView()->layoutAnalyzer())
On 2015/04/30 at 23:32:35, esprehn wrote:
> ditto.

Done.

[benjhayden, 2015-04-30 23:55:37]

The CQ bit was checked by benjhayden@chromium.org

[benjhayden, 2015-04-30 23:55:38]

The patchset sent to the CQ was uploaded after l-g-t-m from esprehn@chromium.org
Link to the patchset: https://codereview.chromium.org/1120833003/#ps60001
(title: "thinger")

[commit-bot: I haz the power, 2015-04-30 23:56:29]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1120833003/60001

[commit-bot: I haz the power, 2015-05-01 01:22:53]

Committed patchset #4 (id:60001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=194781

[Noel Gordon, 2015-05-01 08:10:17]

A revert of this CL (patchset #4 id:60001) has been created in
https://codereview.chromium.org/1122453002/ by noel@chromium.org.

The reason for reverting is: crbug.com/483390  Looks like this change may have
caused the test on that bug to fail on all bots.  A speculative revert might
help resolve that.  Will roll back in otherwise..