Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(545)

Issue 1120823002: Move resource fonts to common location. (Closed)

Created:
5 years, 7 months ago by bungeman-skia
Modified:
5 years, 7 months ago
Reviewers:
joshualitt, mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Move resource fonts to common location. Move resource fonts to resources/fonts, add a destortable font for testing, and clean up how the tests create fonts from resources. R=joshualitt@google.com Committed: https://skia.googlesource.com/skia/+/3ffa126066542590dc7430514a1174e49191b875

Patch Set 1 #

Patch Set 2 : Remove now unused variable. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -79 lines) Patch
M bench/TextBench.cpp View 1 chunk +1 line, -7 lines 0 comments Download
M gm/coloremoji.cpp View 1 1 chunk +2 lines, -9 lines 0 comments Download
M gm/dcshader.cpp View 1 chunk +1 line, -8 lines 0 comments Download
M gm/dftext.cpp View 1 chunk +1 line, -8 lines 0 comments Download
M gm/mixedtextblobs.cpp View 1 chunk +2 lines, -16 lines 0 comments Download
M gyp/ports.gyp View 1 chunk +1 line, -1 line 0 comments Download
D resources/Funkster.ttf View Binary file 0 comments Download
D resources/ReallyBigA.ttf View Binary file 0 comments Download
A + resources/fonts/Distortable.ttf View Binary file 0 comments Download
A + resources/fonts/Funkster.ttf View Binary file 0 comments Download
A + resources/fonts/ReallyBigA.ttf View Binary file 0 comments Download
A + resources/fonts/test.ttc View Binary file 0 comments Download
D resources/test.ttc View Binary file 0 comments Download
M tests/FontHostTest.cpp View 3 chunks +8 lines, -20 lines 0 comments Download
M tests/SerializationTest.cpp View 1 chunk +2 lines, -8 lines 0 comments Download
M tools/Resources.h View 1 chunk +4 lines, -0 lines 0 comments Download
M tools/Resources.cpp View 2 chunks +26 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
bungeman-skia
I was about to add another one of these and didn't want another slightly different ...
5 years, 7 months ago (2015-04-30 20:57:04 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1120823002/1
5 years, 7 months ago (2015-04-30 20:57:39 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1120823002/20001
5 years, 7 months ago (2015-04-30 21:01:36 UTC) #7
joshualitt
On 2015/04/30 21:01:36, I haz the power (commit-bot) wrote: > Dry run: CQ is trying ...
5 years, 7 months ago (2015-04-30 21:06:44 UTC) #8
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 7 months ago (2015-04-30 21:12:42 UTC) #10
bungeman-skia
5 years, 7 months ago (2015-04-30 21:13:04 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
3ffa126066542590dc7430514a1174e49191b875 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698