Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Issue 1120803003: Add a GN flag for the Windows multi-dll build. (Closed)

Created:
5 years, 7 months ago by brettw
Modified:
5 years, 7 months ago
Reviewers:
scottmg
CC:
chromium-reviews, sadrul, kalyank, chromoting-reviews_chromium.org, grt+watch_chromium.org, jam, eme-reviews_chromium.org, darin-cc_chromium.org, wfh+watch_chromium.org, piman+watch_chromium.org, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add a GN flag for the Windows multi-dll build. The first pass of moving the other Chrome-specific build flags out of the root build config file and into the new one. This requires both ffmpeg and Blink changes to finish landing. R=scottmg@chromium.org TBR=ddorwin@chromium.org (widevine) Committed: https://crrev.com/edff53a35780ba2f515c7e8d4f7131c91151e1a3 Cr-Commit-Position: refs/heads/master@{#327854}

Patch Set 1 #

Patch Set 2 : merge #

Patch Set 3 : remerge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+136 lines, -26 lines) Patch
M build/config/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M build/config/BUILDCONFIG.gn View 1 chunk +2 lines, -0 lines 0 comments Download
A build/config/chrome_build.gni View 1 chunk +21 lines, -0 lines 0 comments Download
M build/config/compiler/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M build/config/features.gni View 1 chunk +1 line, -0 lines 0 comments Download
M build/config/mac/mac_sdk.gni View 1 chunk +2 lines, -0 lines 0 comments Download
M build/config/sysroot.gni View 1 chunk +2 lines, -0 lines 0 comments Download
M build/secondary/tools/grit/grit_rule.gni View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/BUILD.gn View 1 6 chunks +54 lines, -6 lines 0 comments Download
M chrome/app/resources/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/policy/BUILD.gn View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_dll.gypi View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/chrome_repack_locales.gni View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/BUILD.gn View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/installer/util/BUILD.gn View 2 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/policy.gypi View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/test/BUILD.gn View 2 1 chunk +1 line, -0 lines 0 comments Download
M chrome/version.gni View 1 3 chunks +20 lines, -4 lines 0 comments Download
M chrome_elf/BUILD.gn View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M components/policy/BUILD.gn View 1 chunk +2 lines, -1 line 0 comments Download
M content/app/BUILD.gn View 1 5 chunks +5 lines, -6 lines 0 comments Download
M content/public/app/BUILD.gn View 1 2 chunks +3 lines, -4 lines 0 comments Download
M content/test/BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download
M gpu/config/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M remoting/remoting_version.gni View 1 chunk +2 lines, -0 lines 0 comments Download
M remoting/webapp/build_template.gni View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/adobe/flash/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/harfbuzz-ng/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/widevine/cdm/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M tools/gn/docs/cookbook.md View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 21 (9 generated)
brettw
5 years, 7 months ago (2015-04-30 21:00:16 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1120803003/1
5 years, 7 months ago (2015-04-30 21:01:01 UTC) #3
scottmg
lgtm
5 years, 7 months ago (2015-04-30 21:06:50 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1120803003/1
5 years, 7 months ago (2015-04-30 21:09:48 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_ninja/builds/20436)
5 years, 7 months ago (2015-04-30 21:25:17 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1120803003/20001
5 years, 7 months ago (2015-04-30 21:43:02 UTC) #12
brettw
TBR ddorwin@chromium.org for widevine build change
5 years, 7 months ago (2015-04-30 21:48:06 UTC) #13
commit-bot: I haz the power
Failed to apply patch for chrome/installer/util/BUILD.gn: While running git apply --index -3 -p1; error: patch ...
5 years, 7 months ago (2015-04-30 22:56:13 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1120803003/40001
5 years, 7 months ago (2015-04-30 23:38:12 UTC) #18
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 7 months ago (2015-05-01 01:10:00 UTC) #19
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/edff53a35780ba2f515c7e8d4f7131c91151e1a3 Cr-Commit-Position: refs/heads/master@{#327854}
5 years, 7 months ago (2015-05-01 01:10:50 UTC) #20
rickyz (no longer on Chrome)
5 years, 7 months ago (2015-05-01 01:43:39 UTC) #21
Message was sent while issue was closed.
A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/1117063004/ by rickyz@chromium.org.

The reason for reverting is: May have caused some link errors on windows:
https://build.chromium.org/p/chromium.win/builders/Win%20x64%20GN/builds/814.

Powered by Google App Engine
This is Rietveld 408576698