Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(298)

Side by Side Diff: extensions/common/one_shot_event.h

Issue 1120793007: [extensions] Replace MessageLoopProxy usage with ThreadTaskRunnerHandle (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed Dependency over component module by removing file Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « extensions/browser/sandboxed_unpacker_unittest.cc ('k') | extensions/common/one_shot_event.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef EXTENSIONS_COMMON_ONE_SHOT_EVENT_H_ 5 #ifndef EXTENSIONS_COMMON_ONE_SHOT_EVENT_H_
6 #define EXTENSIONS_COMMON_ONE_SHOT_EVENT_H_ 6 #define EXTENSIONS_COMMON_ONE_SHOT_EVENT_H_
7 7
8 #include <vector> 8 #include <vector>
9 9
10 #include "base/callback_forward.h" 10 #include "base/callback_forward.h"
11 #include "base/logging.h" 11 #include "base/logging.h"
12 #include "base/memory/ref_counted.h" 12 #include "base/memory/ref_counted.h"
13 #include "base/memory/weak_ptr.h" 13 #include "base/memory/weak_ptr.h"
14 #include "base/threading/thread_checker.h" 14 #include "base/threading/thread_checker.h"
15 15
16 namespace base { 16 namespace base {
17 class TaskRunner; 17 class SingleThreadTaskRunner;
18 class TimeDelta; 18 class TimeDelta;
19 } 19 }
20 20
21 namespace tracked_objects { 21 namespace tracked_objects {
22 class Location; 22 class Location;
23 } 23 }
24 24
25 namespace extensions { 25 namespace extensions {
26 26
27 // This class represents an event that's expected to happen once. It 27 // This class represents an event that's expected to happen once. It
(...skipping 31 matching lines...) Expand 10 before | Expand all | Expand 10 after
59 // becomes true. If called with |delay|, then the task will happen 59 // becomes true. If called with |delay|, then the task will happen
60 // (roughly) |delay| after is_signaled(), *not* |delay| after the 60 // (roughly) |delay| after is_signaled(), *not* |delay| after the
61 // post. Inside |task|, if this OneShotEvent is still alive, 61 // post. Inside |task|, if this OneShotEvent is still alive,
62 // CHECK(is_signaled()) will never fail (which implies that 62 // CHECK(is_signaled()) will never fail (which implies that
63 // OneShotEvent::Reset() doesn't exist). 63 // OneShotEvent::Reset() doesn't exist).
64 // 64 //
65 // If |*this| is destroyed before being released, none of these 65 // If |*this| is destroyed before being released, none of these
66 // tasks will be executed. 66 // tasks will be executed.
67 // 67 //
68 // Omitting the |runner| argument indicates that |task| should run 68 // Omitting the |runner| argument indicates that |task| should run
69 // on MessageLoopProxy::current(). 69 // on current thread's TaskRunner.
70 // 70 //
71 // Tasks may be run in an arbitrary order, not just FIFO. Tasks 71 // Tasks may be run in an arbitrary order, not just FIFO. Tasks
72 // will never be called on the current thread before this function 72 // will never be called on the current thread before this function
73 // returns. Beware that there's no simple way to wait for all tasks 73 // returns. Beware that there's no simple way to wait for all tasks
74 // on a OneShotEvent to complete, so it's almost never safe to use 74 // on a OneShotEvent to complete, so it's almost never safe to use
75 // base::Unretained() when creating one. 75 // base::Unretained() when creating one.
76 // 76 //
77 // Const because Post() doesn't modify the logical state of this 77 // Const because Post() doesn't modify the logical state of this
78 // object (which is just the is_signaled() bit). 78 // object (which is just the is_signaled() bit).
79 void Post(const tracked_objects::Location& from_here, 79 void Post(const tracked_objects::Location& from_here,
80 const base::Closure& task) const; 80 const base::Closure& task) const;
81 void Post(const tracked_objects::Location& from_here, 81 void Post(const tracked_objects::Location& from_here,
82 const base::Closure& task, 82 const base::Closure& task,
83 const scoped_refptr<base::TaskRunner>& runner) const; 83 const scoped_refptr<base::SingleThreadTaskRunner>& runner) const;
84 void PostDelayed(const tracked_objects::Location& from_here, 84 void PostDelayed(const tracked_objects::Location& from_here,
85 const base::Closure& task, 85 const base::Closure& task,
86 const base::TimeDelta& delay) const; 86 const base::TimeDelta& delay) const;
87 87
88 private: 88 private:
89 struct TaskInfo; 89 struct TaskInfo;
90 90
91 void PostImpl(const tracked_objects::Location& from_here, 91 void PostImpl(const tracked_objects::Location& from_here,
92 const base::Closure& task, 92 const base::Closure& task,
93 const scoped_refptr<base::TaskRunner>& runner, 93 const scoped_refptr<base::SingleThreadTaskRunner>& runner,
94 const base::TimeDelta& delay) const; 94 const base::TimeDelta& delay) const;
95 95
96 base::ThreadChecker thread_checker_; 96 base::ThreadChecker thread_checker_;
97 97
98 bool signaled_; 98 bool signaled_;
99 99
100 // The task list is mutable because it's not part of the logical 100 // The task list is mutable because it's not part of the logical
101 // state of the object. This lets us return const references to the 101 // state of the object. This lets us return const references to the
102 // OneShotEvent to clients that just want to run tasks through it 102 // OneShotEvent to clients that just want to run tasks through it
103 // without worrying that they'll signal the event. 103 // without worrying that they'll signal the event.
104 // 104 //
105 // Optimization note: We could reduce the size of this class to a 105 // Optimization note: We could reduce the size of this class to a
106 // single pointer by storing |signaled_| in the low bit of a 106 // single pointer by storing |signaled_| in the low bit of a
107 // pointer, and storing the size and capacity of the array (if any) 107 // pointer, and storing the size and capacity of the array (if any)
108 // on the far end of the pointer. 108 // on the far end of the pointer.
109 mutable std::vector<TaskInfo> tasks_; 109 mutable std::vector<TaskInfo> tasks_;
110 }; 110 };
111 111
112 } // namespace extensions 112 } // namespace extensions
113 113
114 #endif // EXTENSIONS_COMMON_ONE_SHOT_EVENT_H_ 114 #endif // EXTENSIONS_COMMON_ONE_SHOT_EVENT_H_
OLDNEW
« no previous file with comments | « extensions/browser/sandboxed_unpacker_unittest.cc ('k') | extensions/common/one_shot_event.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698