Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(374)

Issue 1120793007: [extensions] Replace MessageLoopProxy usage with ThreadTaskRunnerHandle (Closed)

Created:
5 years, 7 months ago by Pranay
Modified:
5 years, 7 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org, anujsharma
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Replace MessageLoopProxy usage with ThreadTaskRunnerHandle in extensions module. MessageLoopProxy is deprecated. This basically does a search and replace of: MessageLoopProxy::current() -> ThreadTaskRunnerHandle::Get(). MessageLoopProxy -> SingleThreadTaskRunner BUG=391045 Committed: https://crrev.com/7b7ceb183957fc55735153fbacb73a012a69b2cf Cr-Commit-Position: refs/heads/master@{#328313}

Patch Set 1 #

Total comments: 4

Patch Set 2 : Fixed Review Comments #

Patch Set 3 : Updated patch #

Patch Set 4 : Fixed Dependency over component module by removing file #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -23 lines) Patch
M extensions/browser/api/declarative/declarative_api.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M extensions/browser/sandboxed_unpacker_unittest.cc View 1 2 chunks +3 lines, -3 lines 0 comments Download
M extensions/common/one_shot_event.h View 1 4 chunks +4 lines, -4 lines 0 comments Download
M extensions/common/one_shot_event.cc View 3 chunks +13 lines, -11 lines 0 comments Download
M extensions/common/one_shot_event_unittest.cc View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M extensions/renderer/api/serial/serial_api_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 16 (6 generated)
Pranay
PTAL Thanks
5 years, 7 months ago (2015-05-04 06:34:45 UTC) #1
Pranay
PTAL Thanks
5 years, 7 months ago (2015-05-04 06:41:09 UTC) #3
Ken Rockot(use gerrit already)
lgtm https://codereview.chromium.org/1120793007/diff/1/extensions/browser/sandboxed_unpacker_unittest.cc File extensions/browser/sandboxed_unpacker_unittest.cc (right): https://codereview.chromium.org/1120793007/diff/1/extensions/browser/sandboxed_unpacker_unittest.cc#newcode9 extensions/browser/sandboxed_unpacker_unittest.cc:9: #include "base/message_loop/message_loop.h" is this header still needed? https://codereview.chromium.org/1120793007/diff/1/extensions/common/one_shot_event.h ...
5 years, 7 months ago (2015-05-04 18:19:58 UTC) #4
Pranay
https://codereview.chromium.org/1120793007/diff/1/extensions/browser/sandboxed_unpacker_unittest.cc File extensions/browser/sandboxed_unpacker_unittest.cc (right): https://codereview.chromium.org/1120793007/diff/1/extensions/browser/sandboxed_unpacker_unittest.cc#newcode9 extensions/browser/sandboxed_unpacker_unittest.cc:9: #include "base/message_loop/message_loop.h" Not needed, got confused with MessageLoopRunner :) ...
5 years, 7 months ago (2015-05-05 03:07:58 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1120793007/20001
5 years, 7 months ago (2015-05-05 03:08:56 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_dbg on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_dbg/builds/68399)
5 years, 7 months ago (2015-05-05 03:22:35 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1120793007/60001
5 years, 7 months ago (2015-05-05 10:49:31 UTC) #13
Pranay
Done
5 years, 7 months ago (2015-05-05 10:50:23 UTC) #14
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 7 months ago (2015-05-05 12:13:00 UTC) #15
commit-bot: I haz the power
5 years, 7 months ago (2015-05-05 12:13:57 UTC) #16
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/7b7ceb183957fc55735153fbacb73a012a69b2cf
Cr-Commit-Position: refs/heads/master@{#328313}

Powered by Google App Engine
This is Rietveld 408576698