Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(580)

Issue 1120753010: MIPS: Fix long branch mode and FPU branches. (Closed)

Created:
5 years, 7 months ago by dusmil.imgtec
Modified:
5 years, 7 months ago
Reviewers:
djordje.pesic, balazs.kilvady, paul.l..., akos.palfi.imgtec
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

MIPS: Fix long branch mode and FPU branches. - Add long branche mode for FPU branches. - Fix FPU branches for unordered conditions. - Provide FPU [un]ordered condition negation schema. TEST=mjsunit/miror-objects, constant-folding-2, external-array BUG= Committed: https://crrev.com/c37f439b70b5b7bb97cbed77c322db787947861c Cr-Commit-Position: refs/heads/master@{#28241}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fixed typo. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+326 lines, -83 lines) Patch
M src/mips/constants-mips.h View 5 chunks +44 lines, -7 lines 0 comments Download
M src/mips/deoptimizer-mips.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M src/mips/lithium-codegen-mips.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M src/mips/macro-assembler-mips.h View 1 chunk +4 lines, -0 lines 0 comments Download
M src/mips/macro-assembler-mips.cc View 7 chunks +104 lines, -25 lines 0 comments Download
M src/mips64/constants-mips64.h View 4 chunks +42 lines, -5 lines 0 comments Download
M src/mips64/deoptimizer-mips64.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M src/mips64/lithium-codegen-mips64.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M src/mips64/macro-assembler-mips64.h View 1 chunk +5 lines, -0 lines 0 comments Download
M src/mips64/macro-assembler-mips64.cc View 1 5 chunks +110 lines, -29 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
dusmil.imgtec
5 years, 7 months ago (2015-05-05 13:27:32 UTC) #2
paul.l...
LGTM, after you fix the one issue commented on.... https://codereview.chromium.org/1120753010/diff/1/src/mips64/macro-assembler-mips64.cc File src/mips64/macro-assembler-mips64.cc (right): https://codereview.chromium.org/1120753010/diff/1/src/mips64/macro-assembler-mips64.cc#newcode1710 src/mips64/macro-assembler-mips64.cc:1710: ...
5 years, 7 months ago (2015-05-05 16:07:21 UTC) #3
dusmil.imgtec
https://codereview.chromium.org/1120753010/diff/1/src/mips64/macro-assembler-mips64.cc File src/mips64/macro-assembler-mips64.cc (right): https://codereview.chromium.org/1120753010/diff/1/src/mips64/macro-assembler-mips64.cc#newcode1710 src/mips64/macro-assembler-mips64.cc:1710: c(OLT, sizeField, cmp1, cmp2); On 2015/05/05 16:07:21, paul.l... wrote: ...
5 years, 7 months ago (2015-05-05 18:11:29 UTC) #4
paul.l...
lgtm
5 years, 7 months ago (2015-05-05 18:20:01 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1120753010/20001
5 years, 7 months ago (2015-05-05 18:53:35 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-05-05 19:20:47 UTC) #8
commit-bot: I haz the power
5 years, 7 months ago (2015-05-05 19:21:08 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c37f439b70b5b7bb97cbed77c322db787947861c
Cr-Commit-Position: refs/heads/master@{#28241}

Powered by Google App Engine
This is Rietveld 408576698