Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 1120733002: Narrow the instrumentation to track jank in HostResolverImpl. (Closed)

Created:
5 years, 7 months ago by eroman
Modified:
5 years, 7 months ago
Reviewers:
Peter Kasting
CC:
chromium-reviews, cbentzel+watch_chromium.org, mmenke
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Narrow the instrumentation to track jank in HostResolverImpl. I am fairly confident this is coming from IsGloballyReachable(), which seems to have a dependency on UDP sockets, so focused the instrumentation there. One weakness of this instrumentation is it doesn't separate out some of the non-trivial work being done by local variable's destructors (most notably deletion of the UDP sockets, which will likely be hitting issue 165382). BUG=455942 TBR=pkasting@chromium.org Committed: https://crrev.com/0eb394e2b9fa06ff225084969300fe65b8f17dfc Cr-Commit-Position: refs/heads/master@{#327831}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -15 lines) Patch
M net/dns/host_resolver_impl.cc View 4 chunks +20 lines, -15 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
eroman
5 years, 7 months ago (2015-04-30 18:41:58 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1120733002/1
5 years, 7 months ago (2015-04-30 19:56:19 UTC) #4
Peter Kasting
In order to measure the effect of local destructors, I often add local scoping blocks ...
5 years, 7 months ago (2015-04-30 20:36:54 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-04-30 23:25:53 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-04-30 23:27:04 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0eb394e2b9fa06ff225084969300fe65b8f17dfc
Cr-Commit-Position: refs/heads/master@{#327831}

Powered by Google App Engine
This is Rietveld 408576698