Issue 1120703003: Try to take advantage of unused bytes at end of string.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1120703003: Try to take advantage of unused bytes at end of string. (Closed)

Created:
5 years, 7 months ago by Tom Sepez

Modified:
5 years, 7 months ago

Reviewers:
Lei Zhang

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Try to take advantage of unused bytes at end of CFX_ByteString. Given the representation of StringData, it seems sub-optimal not to be doing this. R=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/cd051604b1b5f8555cf692b91d0105d7a7117feb

Created: 5 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -3 lines)			Patch
	M	core/src/fxcrt/fx_basic_bstring.cpp	View		1 chunk	+15 lines, -3 lines	0 comments	Download

Total messages: 4 (1 generated)

Tom Sepez

5 years, 7 months ago (2015-04-30 22:21:22 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
cd051604b1b5f8555cf692b91d0105d7a7117feb (presubmit successful).