Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Issue 1120653008: Add myself to Authors (Closed)

Created:
5 years, 7 months ago by lopes
Modified:
5 years, 7 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add myself to Authors Add myself to Authors so that I can contribute fix for 477894 BUG=477894 Committed: https://crrev.com/4d485a892b5e7796780b1549fa28c167ac1a31a8 Cr-Commit-Position: refs/heads/master@{#328089}

Patch Set 1 #

Patch Set 2 : author file merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M AUTHORS View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 19 (7 generated)
lopes
Add myself as an author so I can contribute fix for 477894
5 years, 7 months ago (2015-05-01 22:23:49 UTC) #2
leviw_travelin_and_unemployed
lgtm I don't think I can actually approve this patch, but let's find out.
5 years, 7 months ago (2015-05-02 22:26:18 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1120653008/1
5 years, 7 months ago (2015-05-02 22:26:25 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_ninja/builds/20989)
5 years, 7 months ago (2015-05-02 22:28:51 UTC) #7
leviw_travelin_and_unemployed
Your AUTHORS file is out of date :p
5 years, 7 months ago (2015-05-03 00:24:19 UTC) #8
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1120653008/20001
5 years, 7 months ago (2015-05-03 16:33:45 UTC) #11
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 7 months ago (2015-05-03 16:40:42 UTC) #13
lopes
I'm not sure if I can commit this so I'll hold off.
5 years, 7 months ago (2015-05-03 16:42:04 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1120653008/20001
5 years, 7 months ago (2015-05-04 02:36:29 UTC) #16
leviw_travelin_and_unemployed
On 2015/05/03 at 16:42:04, lopes92290 wrote: > I'm not sure if I can commit this ...
5 years, 7 months ago (2015-05-04 02:36:49 UTC) #17
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-05-04 02:36:58 UTC) #18
commit-bot: I haz the power
5 years, 7 months ago (2015-05-04 02:38:03 UTC) #19
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/4d485a892b5e7796780b1549fa28c167ac1a31a8
Cr-Commit-Position: refs/heads/master@{#328089}

Powered by Google App Engine
This is Rietveld 408576698