|
|
Created:
5 years, 7 months ago by lopes Modified:
5 years, 7 months ago Reviewers:
leviw_travelin_and_unemployed CC:
chromium-reviews Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionAdd myself to Authors
Add myself to Authors so that I can contribute fix for 477894
BUG=477894
Committed: https://crrev.com/4d485a892b5e7796780b1549fa28c167ac1a31a8
Cr-Commit-Position: refs/heads/master@{#328089}
Patch Set 1 #Patch Set 2 : author file merge #Messages
Total messages: 19 (7 generated)
lopes92290@gmail.com changed reviewers: + leviw@chromium.org
Add myself as an author so I can contribute fix for 477894
The CQ bit was checked by leviw@chromium.org
lgtm I don't think I can actually approve this patch, but let's find out.
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1120653008/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
Your AUTHORS file is out of date :p
The CQ bit was checked by lopes92290@gmail.com to run a CQ dry run
The patchset sent to the CQ was uploaded after l-g-t-m from leviw@chromium.org Link to the patchset: https://codereview.chromium.org/1120653008/#ps20001 (title: "author file merge")
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1120653008/20001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
I'm not sure if I can commit this so I'll hold off.
The CQ bit was checked by leviw@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1120653008/20001
On 2015/05/03 at 16:42:04, lopes92290 wrote: > I'm not sure if I can commit this so I'll hold off. I checked the commit button. If presubmit is happy with my L-G-T-M, we're good.
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/4d485a892b5e7796780b1549fa28c167ac1a31a8 Cr-Commit-Position: refs/heads/master@{#328089} |