Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Unified Diff: src/bootstrapper.cc

Issue 1120613002: VectorICs: built-in function apply should use an IC. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/ia32/builtins-ia32.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/bootstrapper.cc
diff --git a/src/bootstrapper.cc b/src/bootstrapper.cc
index 1658d646182e674bd04275a693bf87d7f7fd7219..de6eade27c052c76cd4ac8f6d3fc955b85be6412 100644
--- a/src/bootstrapper.cc
+++ b/src/bootstrapper.cc
@@ -1731,18 +1731,6 @@ void Genesis::InitializeGlobal_harmony_reflect() {
Handle<JSFunction> construct = InstallFunction(
builtins, "$reflectConstruct", JS_OBJECT_TYPE, JSObject::kHeaderSize,
MaybeHandle<JSObject>(), Builtins::kReflectConstruct);
- if (FLAG_vector_ics) {
- // Apply embeds an IC, so we need a type vector of size 1 in the shared
- // function info.
- FeedbackVectorSpec spec(0, Code::CALL_IC);
- Handle<TypeFeedbackVector> feedback_vector =
- factory()->NewTypeFeedbackVector(&spec);
- apply->shared()->set_feedback_vector(*feedback_vector);
-
- feedback_vector = factory()->NewTypeFeedbackVector(&spec);
- construct->shared()->set_feedback_vector(*feedback_vector);
- }
-
apply->shared()->set_internal_formal_parameter_count(3);
apply->shared()->set_length(3);
@@ -2181,14 +2169,6 @@ bool Genesis::InstallNatives() {
Handle<JSFunction> apply =
InstallFunction(proto, "apply", JS_OBJECT_TYPE, JSObject::kHeaderSize,
MaybeHandle<JSObject>(), Builtins::kFunctionApply);
- if (FLAG_vector_ics) {
- // Apply embeds an IC, so we need a type vector of size 1 in the shared
- // function info.
- FeedbackVectorSpec spec(0, Code::CALL_IC);
- Handle<TypeFeedbackVector> feedback_vector =
- factory()->NewTypeFeedbackVector(&spec);
- apply->shared()->set_feedback_vector(*feedback_vector);
- }
// Make sure that Function.prototype.call appears to be compiled.
// The code will never be called, but inline caching for call will
« no previous file with comments | « no previous file | src/ia32/builtins-ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698