Issue 112059: Correct the hit testing so that the window controls and title bar will get ta...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 112059: Correct the hit testing so that the window controls and title bar will get ta... (Closed)

Created:
11 years, 7 months ago by pink (ping after 24hrs)

Modified:
9 years, 7 months ago

Reviewers:
viettrungluu-gmail, rohitrao (ping after 24h)

CC:
chromium-reviews_googlegroups.com, Nicholas Jitkoff

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Correct the hit testing so that the window controls and title bar will get targeted when the window isn't the foreground window. BUG=12505 TEST=closing and minimizing background windows. all mouse interactions with foreground tabs. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=16875

Patch Set 1 #

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+20 lines, -0 lines)			Patch
	M	chrome/browser/cocoa/tab_strip_view.mm	View		1 chunk	+20 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

rohitrao (ping after 24h)

On 2009/05/26 17:16:12, pink wrote: > rohit: review > cole: cc'd just for info LGTM ...

11 years, 7 months ago (2009-05-26 17:31:12 UTC) #2

viettrungluu-gmail

11 years, 5 months ago (2009-07-19 02:21:04 UTC) #3

My submitted patch for bug 12286 supercedes the fix for this bug:
<http://code.google.com/p/chromium/issues/detail?id=12286>
<http://codereview.chromium.org/159062>

(so it has to be checked that my patch also properly and completely fixes this
bug)

Expand Messages | Collapse Messages