Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(523)

Issue 112059: Correct the hit testing so that the window controls and title bar will get ta... (Closed)

Created:
11 years, 7 months ago by pink (ping after 24hrs)
Modified:
9 years, 7 months ago
CC:
chromium-reviews_googlegroups.com, Nicholas Jitkoff
Visibility:
Public.

Description

Correct the hit testing so that the window controls and title bar will get targeted when the window isn't the foreground window. BUG=12505 TEST=closing and minimizing background windows. all mouse interactions with foreground tabs. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=16875

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -0 lines) Patch
M chrome/browser/cocoa/tab_strip_view.mm View 1 chunk +20 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
pink (ping after 24hrs)
rohit: review cole: cc'd just for info
11 years, 7 months ago (2009-05-26 17:16:12 UTC) #1
rohitrao (ping after 24h)
On 2009/05/26 17:16:12, pink wrote: > rohit: review > cole: cc'd just for info LGTM ...
11 years, 7 months ago (2009-05-26 17:31:12 UTC) #2
viettrungluu-gmail
11 years, 5 months ago (2009-07-19 02:21:04 UTC) #3
My submitted patch for bug 12286 supercedes the fix for this bug:
<http://code.google.com/p/chromium/issues/detail?id=12286>
<http://codereview.chromium.org/159062>

(so it has to be checked that my patch also properly and completely fixes this
bug)

Powered by Google App Engine
This is Rietveld 408576698