Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1120573002: JSON serializer should fail gracefully for special value wrappers. (Closed)

Created:
5 years, 7 months ago by Yang
Modified:
5 years, 7 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

JSON serializer should fail gracefully for special value wrappers. R=mstarzinger@chromium.org BUG=chromium:471702 LOG=N Committed: https://crrev.com/7681432dbfca3dc44056cd50fa09a5292f3f4711 Cr-Commit-Position: refs/heads/master@{#28154}

Patch Set 1 #

Patch Set 2 : removing unnecessary dcheck #

Patch Set 3 : fix test case #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -5 lines) Patch
M src/json-stringifier.h View 1 1 chunk +5 lines, -2 lines 0 comments Download
A + test/mjsunit/regress/regress-crbug-471702.js View 1 2 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
Yang
5 years, 7 months ago (2015-04-30 08:44:23 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1120573002/1
5 years, 7 months ago (2015-04-30 08:44:45 UTC) #3
Michael Starzinger
LGTM.
5 years, 7 months ago (2015-04-30 08:46:41 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1120573002/20001
5 years, 7 months ago (2015-04-30 08:53:04 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_nodcheck_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_nodcheck_rel/builds/2311)
5 years, 7 months ago (2015-04-30 09:03:13 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1120573002/40001
5 years, 7 months ago (2015-04-30 09:21:27 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 7 months ago (2015-04-30 10:02:21 UTC) #12
commit-bot: I haz the power
5 years, 7 months ago (2015-04-30 10:02:35 UTC) #13
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/7681432dbfca3dc44056cd50fa09a5292f3f4711
Cr-Commit-Position: refs/heads/master@{#28154}

Powered by Google App Engine
This is Rietveld 408576698