Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 1120553002: [storage] Replace MessageLoopProxy usage with ThreadTaskRunnerHandle (Closed)

Created:
5 years, 7 months ago by Pranay
Modified:
5 years, 7 months ago
Reviewers:
kinuko, piman
CC:
chromium-reviews, kinuko+fileapi, nhiroki, tzik, anujsharma
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Replace MessageLoopProxy usage with ThreadTaskRunnerHandle in complete storage module. MessageLoopProxy is deprecated. This basically does a search and replace of: MessageLoopProxy::current() -> ThreadTaskRunnerHandle::Get(). MessageLoopProxy -> SingleThreadTaskRunner BUG=391045 Committed: https://crrev.com/4e254712d7fddbc1e5dbad750dce5aede3dab613 Cr-Commit-Position: refs/heads/master@{#328095}

Patch Set 1 #

Total comments: 4

Patch Set 2 : Fixed Review Comments #

Total comments: 1

Patch Set 3 : Fixed Review Nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -47 lines) Patch
M storage/browser/blob/blob_storage_context.cc View 1 2 2 chunks +3 lines, -2 lines 0 comments Download
M storage/browser/blob/blob_url_request_job.h View 1 3 chunks +3 lines, -3 lines 0 comments Download
M storage/browser/blob/blob_url_request_job.cc View 1 4 chunks +4 lines, -5 lines 0 comments Download
M storage/browser/blob/blob_url_request_job_factory.h View 3 chunks +3 lines, -3 lines 0 comments Download
M storage/browser/blob/blob_url_request_job_factory.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M storage/browser/blob/shareable_file_reference.cc View 1 chunk +0 lines, -1 line 0 comments Download
M storage/browser/database/database_quota_client.h View 3 chunks +3 lines, -3 lines 0 comments Download
M storage/browser/database/database_quota_client.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M storage/browser/database/database_tracker.h View 3 chunks +3 lines, -3 lines 0 comments Download
M storage/browser/database/database_tracker.cc View 2 chunks +1 line, -2 lines 0 comments Download
M storage/browser/fileapi/async_file_util_adapter.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M storage/browser/fileapi/file_system_dir_url_request_job.h View 1 chunk +0 lines, -1 line 0 comments Download
M storage/browser/fileapi/file_system_url_request_job.cc View 1 chunk +0 lines, -1 line 0 comments Download
M storage/browser/fileapi/file_system_url_request_job_factory.h View 1 chunk +0 lines, -4 lines 0 comments Download
M storage/browser/fileapi/file_writer_delegate.cc View 1 chunk +0 lines, -1 line 0 comments Download
M storage/browser/quota/quota_task.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M storage/common/database/database_connections.h View 2 chunks +2 lines, -2 lines 0 comments Download
M storage/common/database/database_connections.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 20 (8 generated)
Pranay
PTAL Thanks
5 years, 7 months ago (2015-04-30 07:24:00 UTC) #2
kinuko
Can you run try jobs? https://codereview.chromium.org/1120553002/diff/1/storage/browser/blob/blob_storage_context.cc File storage/browser/blob/blob_storage_context.cc (right): https://codereview.chromium.org/1120553002/diff/1/storage/browser/blob/blob_storage_context.cc#newcode84 storage/browser/blob/blob_storage_context.cc:84: )); Can this be ...
5 years, 7 months ago (2015-04-30 07:52:06 UTC) #4
Pranay
Hi Kinuko, Thanks for the review. I have updated the changes in new patch set. ...
5 years, 7 months ago (2015-04-30 10:11:52 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1120553002/20001
5 years, 7 months ago (2015-04-30 11:00:37 UTC) #7
kinuko
lgtm with one more nit https://codereview.chromium.org/1120553002/diff/20001/storage/browser/blob/blob_storage_context.cc File storage/browser/blob/blob_storage_context.cc (right): https://codereview.chromium.org/1120553002/diff/20001/storage/browser/blob/blob_storage_context.cc#newcode83 storage/browser/blob/blob_storage_context.cc:83: )); Um, sorry I ...
5 years, 7 months ago (2015-04-30 12:44:49 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1120553002/20001
5 years, 7 months ago (2015-04-30 14:48:48 UTC) #11
kinuko
On 2015/04/30 12:44:49, kinuko wrote: > lgtm with one more nit > > https://codereview.chromium.org/1120553002/diff/20001/storage/browser/blob/blob_storage_context.cc > ...
5 years, 7 months ago (2015-04-30 15:05:12 UTC) #13
Pranay
Hi Kinuko, Sorry for that :) Have updated the patch set. Thanks
5 years, 7 months ago (2015-05-04 03:06:57 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1120553002/40001
5 years, 7 months ago (2015-05-04 03:07:22 UTC) #17
Pranay
https://codereview.chromium.org/1120553002/diff/1/storage/browser/blob/blob_storage_context.cc File storage/browser/blob/blob_storage_context.cc (right): https://codereview.chromium.org/1120553002/diff/1/storage/browser/blob/blob_storage_context.cc#newcode84 storage/browser/blob/blob_storage_context.cc:84: )); On 2015/04/30 07:52:06, kinuko wrote: > Can this ...
5 years, 7 months ago (2015-05-04 03:20:58 UTC) #18
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 7 months ago (2015-05-04 04:12:40 UTC) #19
commit-bot: I haz the power
5 years, 7 months ago (2015-05-04 04:13:38 UTC) #20
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/4e254712d7fddbc1e5dbad750dce5aede3dab613
Cr-Commit-Position: refs/heads/master@{#328095}

Powered by Google App Engine
This is Rietveld 408576698