[PDF] Fix bug in ToUnicode table generation for Type 3 fonts.

[PDF] Fix bug in ToUnicode table generation for Type 3 fonts.

True glyphIDs where being using in the Type3 ToUnicode table instead of IDs of 1-255.  This causes poppler to complain about each entry.

BUG:skia:1565

Committed: http://code.google.com/p/skia/source/detail?r=12625

[bungeman-skia, 2013-12-11 17:58:10]

I'm going to say lgtm because the change itself looks ok, but I'm wondering if
the same issue occurs anyway if one used more than 256 glyphs in the source
font? Does the source font get split into multiple type3 fonts? If so, then I
have no issue with this at all.

[vandebo (ex-Chrome), 2013-12-11 18:06:59]

On 2013/12/11 17:58:10, bungeman1 wrote:
> I'm going to say lgtm because the change itself looks ok, but I'm wondering if
> the same issue occurs anyway if one used more than 256 glyphs in the source
> font? Does the source font get split into multiple type3 fonts? If so, then I
> have no issue with this at all.

Yea, Type3 fonts are treated the same as Type1 fonts.  In both cases, if there
are glyphs used in different blocks of 255 glyphids, multiple fonts are
generated.  ToUnicode isn't generated for Type1 fonts though.

[commit-bot: I haz the power, 2013-12-11 18:07:12]

CQ is trying da patch. Follow status at
https://skia-tree-status.appspot.com/cq/vandebo@chromium.org/112053005/1

[commit-bot: I haz the power, 2013-12-11 18:47:20]

Change committed as 12625