Allow the max url length to be overridden

content/public/common/url_utils.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_PUBLIC_COMMON_URL_UTILS_H_
 #define CONTENT_PUBLIC_COMMON_URL_UTILS_H_
 
+#include <stddef.h>         // For size_t
+
 #include "content/common/content_export.h"
 
 class GURL;
 
 namespace content {
 
 // Null terminated list of schemes that are savable. This function can be
 // invoked on any thread.
 CONTENT_EXPORT const char* const* GetSavableSchemes();
 
 // Returns true if the url has a scheme for WebUI.  See also
 // WebUIControllerFactory::UseWebUIForURL in the browser process.
 CONTENT_EXPORT bool HasWebUIScheme(const GURL& url);
 
 // Check whether we can do the saving page operation for the specified URL.
 CONTENT_EXPORT bool IsSavableURL(const GURL& url);
 
+// The maximum number of characters in the URL that we're willing to accept
+// in the browser process. It is set low enough to avoid damage to the browser
+// but high enough that a web site can abuse location.hash for a little storage.
+// We have different values for "max accepted" and "max displayed" because
+// a data: URI may be legitimately massive, but the full URI would kill all
+// known operating systems if you dropped it into a UI control.
+CONTENT_EXPORT size_t MaxURLChars();

[boliu, 2013/12/10 21:46:47]

Oh, just noticed, this doesn't need to be exported since all usage is under
content. But then the old constant was exported... I guess let content owners
decide.

[Tom Sepez, 2013/12/10 22:12:19]

nit: not clear which process this needs to be called in, and whether it affects
other processes (it doesn't) for the case of clank. You may wind up with this
set to different values in different processes.

[boliu, 2013/12/10 22:21:59]

The implied usage is call this early in start up before forking child processes.
content::SetContentClient is another example of this.

Then of course we can make this explicit with a comment. Not sure if there is
anything to assert though.

[jam, 2013/12/11 17:23:32]

nit: usually getters have a Get prefix, which makes it clear what the method
does

[Kristian Monsen, 2013/12/11 22:05:42]

Done. Should it also have the Google3 syntax for getters, get_max_url_chars?

[Kristian Monsen, 2013/12/11 22:05:42]

Done. Added a comment.

+
+#if defined(OS_ANDROID)
+// Set a new max size for URL's that we are willing to accept in the browser
+// process.
+// Should not be used exept by Android WebView for backwards compatibility.

[jam, 2013/12/11 17:23:32]

nit: except

[Kristian Monsen, 2013/12/11 22:05:42]

Done.

+CONTENT_EXPORT void SetMaxURLChars(size_t maxChars);

[jam, 2013/12/11 17:23:32]

nit: max_chars per style guide

[Kristian Monsen, 2013/12/11 22:05:42]

Done.

+#endif
+
 }  // namespace content
 
 #endif  // CONTENT_PUBLIC_COMMON_URL_UTILS_H_