Get generate_dump compiling on Windows

util/file/basename.h

Index: util/file/basename.h
diff --git a/test/thread.cc b/util/file/basename.h
similarity index 69%
copy from test/thread.cc
copy to util/file/basename.h
index baeeafa632152c4edd71aa04be6a4d32a0824d2e..c09815793af3fd6d78739b1a1a5aa26a4c465d32 100644
--- a/test/thread.cc
+++ b/util/file/basename.h
@@ -12,19 +12,17 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-#include "test/thread.h"
+#ifndef CRASHPAD_UTIL_FILE_BASENAME_H_
+#define CRASHPAD_UTIL_FILE_BASENAME_H_
 
-#include "gtest/gtest.h"
+#include <string>
 
 namespace crashpad {
-namespace test {
 
-Thread::Thread() : platform_thread_(0) {
-}
+//! \brief Splits a file path into the directory and filename parts, and returns

[Mark Mentovai, 2015/05/04 21:21:58]

I was going to say that this should be done in compat for Windows, but that’s
got unexpected C semantics that return a pointer to something in the input
string. But this also basically duplicates something in file_path. Is it more
sensible to have this, or to use FilePath’s BaseName()?

[scottmg, 2015/05/04 23:30:07]

Oh, for some reason I thought we didn't have all of FilePath's implementation in
mini_chromium yet. I'll drop these, use FilePath::BaseName, and make ToolSupport
take a FilePath for these things.

+//!     the filename.
+std::string Basename(const std::string& path);
 
-Thread::~Thread() {
-  EXPECT_FALSE(platform_thread_);
-}
-
-}  // namespace test
 }  // namespace crashpad
+
+#endif  // CRASHPAD_UTIL_FILE_BASENAME_H_