Get generate_dump compiling on Windows

tools/crashpad_database_util.cc

Index: tools/crashpad_database_util.cc
diff --git a/tools/crashpad_database_util.cc b/tools/crashpad_database_util.cc
index c3d0d899cf3237764c9490a46eff646db7272d6c..f603f3ae554bf7a582fc0c3a777e690633929ef3 100644
--- a/tools/crashpad_database_util.cc
+++ b/tools/crashpad_database_util.cc
@@ -34,6 +34,7 @@
 #include "client/crash_report_database.h"
 #include "client/settings.h"
 #include "tools/tool_support.h"
+#include "util/file/basename.h"
 #include "util/file/file_io.h"
 #include "util/file/file_reader.h"
 #include "util/misc/uuid.h"
@@ -50,11 +51,6 @@ time_t TimeGM(struct tm* tm) {
   return timegm(tm);
 }
 
-std::string Basename(const std::string& path) {

[Mark Mentovai, 2015/05/04 21:21:58]

I’m skipping this for now because I suspect this is going to turn into a merge
conflict with its dependency change in any case.

[scottmg, 2015/05/05 19:26:22]

All gone now.

-  std::string copy(path);
-  return std::string(basename(&copy[0]));
-}
-
 const char* Strptime(const char* buf, const char* format, struct tm* tm) {
   return strptime(buf, format, tm);
 }
@@ -63,13 +59,6 @@ time_t TimeGM(struct tm* tm) {
   return _mkgmtime(tm);
 }
 
-std::string Basename(const std::string& path) {
-  char fname[_MAX_FNAME];
-  char ext[_MAX_EXT];
-  _splitpath(path.c_str(), nullptr, nullptr, fname, ext);
-  return std::string(fname) + std::string(ext);
-}
-
 const char* Strptime(const char* buf, const char* format, struct tm* tm) {
   // TODO(scottmg): strptime implementation.
   NOTREACHED();