Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(490)

Unified Diff: tools/tools.gyp

Issue 1120383003: Get generate_dump compiling on Windows (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@tools
Patch Set: fix mac; no implicit conversion to std::string for StringPiece Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/tool_support.cc ('k') | util/win/process_info.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/tools.gyp
diff --git a/tools/tools.gyp b/tools/tools.gyp
index 49c170561b9471883b650d6c00404668cf09adbe..4876300538fb939969ed240b11c2abf052e77f71 100644
--- a/tools/tools.gyp
+++ b/tools/tools.gyp
@@ -48,6 +48,36 @@
'crashpad_database_util.cc',
],
},
+ {
+ 'target_name': 'generate_dump',
+ 'type': 'executable',
+ 'dependencies': [
+ 'crashpad_tool_support',
+ '../compat/compat.gyp:crashpad_compat',
+ '../minidump/minidump.gyp:crashpad_minidump',
+ '../snapshot/snapshot.gyp:crashpad_snapshot',
+ '../third_party/mini_chromium/mini_chromium.gyp:base',
+ '../util/util.gyp:crashpad_util',
+ ],
+ 'include_dirs': [
+ '..',
+ ],
+ 'sources': [
+ 'generate_dump.cc',
+ ],
+ 'conditions': [
+ ['OS=="mac"', {
+ 'xcode_settings': {
+ 'OTHER_LDFLAGS': [
+ '-sectcreate',
+ '__TEXT',
+ '__info_plist',
+ '<(sectaskaccess_info_plist)'
+ ],
+ },
+ }],
+ ],
+ }
],
'conditions': [
['OS=="mac"', {
@@ -119,32 +149,6 @@
},
},
{
- 'target_name': 'generate_dump',
- 'type': 'executable',
- 'dependencies': [
- 'crashpad_tool_support',
- '../compat/compat.gyp:crashpad_compat',
- '../minidump/minidump.gyp:crashpad_minidump',
- '../snapshot/snapshot.gyp:crashpad_snapshot',
- '../third_party/mini_chromium/mini_chromium.gyp:base',
- '../util/util.gyp:crashpad_util',
- ],
- 'include_dirs': [
- '..',
- ],
- 'sources': [
- 'generate_dump.cc',
- ],
- 'xcode_settings': {
- 'OTHER_LDFLAGS': [
- '-sectcreate',
- '__TEXT',
- '__info_plist',
- '<(sectaskaccess_info_plist)'
- ],
- },
- },
- {
'target_name': 'on_demand_service_tool',
'type': 'executable',
'dependencies': [
« no previous file with comments | « tools/tool_support.cc ('k') | util/win/process_info.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698