minidump/minidump_system_info_writer.cc - Issue 1120383003: Get generate_dump compiling on Windows

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: minidump/minidump_system_info_writer.cc

Issue 1120383003: Get generate_dump compiling on Windows (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@tools

Patch Set: fix mac; no implicit conversion to std::string for StringPiece Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: minidump/minidump_system_info_writer.cc

diff --git a/minidump/minidump_system_info_writer.cc b/minidump/minidump_system_info_writer.cc

index 4797d6ea06322e4640118b6be149f872e4bbcacd..309f3a39de61e9bbc46d5bb09b77940f5ff6270e 100644

--- a/minidump/minidump_system_info_writer.cc

+++ b/minidump/minidump_system_info_writer.cc

@@ -154,6 +154,9 @@ void MinidumpSystemInfoWriter::InitializeFromSnapshot(

case SystemSnapshot::kOperatingSystemMacOSX:

operating_system = kMinidumpOSMacOSX;

break;

+ case SystemSnapshot::kOperatingSystemWindows:

+ operating_system = kMinidumpOSWin32NT;

+ break;

default:

NOTREACHED();

operating_system = kMinidumpOSUnknown;

« no previous file with comments | « compat/win/sys/types.h ('k') | tools/crashpad_database_util.cc » ('j') | no next file with comments »