Get generate_dump compiling on Windows

tools/tool_support.h

Index: tools/tool_support.h
diff --git a/tools/tool_support.h b/tools/tool_support.h
index 47976bc9692c7f3ddb3f26ec0ef4f0c0c6db57bf..ae4d10dd4d83dc658bf7386b63700a1de7fa5ff9 100644
--- a/tools/tool_support.h
+++ b/tools/tool_support.h
@@ -53,6 +53,19 @@ class ToolSupport {
   static void UsageHint(const std::string& me, const char* hint);
 #endif  // OS_POSIX
 
+#if defined(OS_WIN) || DOXYGEN
+  //! \brief Converts \a argv wchar_t UTF16 to UTF8, and passes onwards to a

[Mark Mentovai, 2015/05/05 22:41:36]

`wchar_t`, UTF-16 (dash), UTF-8. Also in the next comment.

[scottmg, 2015/05/05 23:23:53]

Done.

+  //!     UTF8 entry point.
+  //!
+  //! \return The return values of \a entry.
+  static int Wmain(int argc, wchar_t* argv[], int (*entry)(int, char*[]));
+#endif  // OS_WIN
+
+  //! \brief Convert a UTF8 string (typically a path) to the string type
+  //!     suitable for base::FilePath. On POSIX, this is a no-op, on Windows it
+  //!     converts from UTF8 to UTF16.
+  static base::FilePath::StringType UTF8ToFilePathStringType(const char* path);

[Mark Mentovai, 2015/05/05 22:41:36]

path might not be UTF-8. It is on Windows because Wmain will have converted
known UTF-16 to known UTF-8, but on some systems, the native path encoding is
not UTF-8. It’s correct in those cases to just pass whatever string we’ve got on
through to an output string as-is, so the code is correct, but the function name
shouldn’t be misleading in this way.

Unfortunately, any naming like Narrow or MultiByte is then confusing on Windows,
where the strings are actually UTF-8 thanks to Wmain(), and are definitely not
in the encoding that Narrow or MultiByte would imply.

Maybe CommandLineArgumentToFilePathStringType()? That’s pretty wordy.
ArgumentToFilePathStringType()? That’s a little bit ambiguous. Something with
Argv in it?

[scottmg, 2015/05/05 23:23:52]

I went with CommandLineArgumentToFilePathStringType. It's (hopefully) not used
that frequently anyway.

+
  private:
   DISALLOW_IMPLICIT_CONSTRUCTORS(ToolSupport);
 };