Get generate_dump compiling on Windows

tools/crashpad_database_util.cc

 // Copyright 2015 The Crashpad Authors. All rights reserved.
 //
 // Licensed under the Apache License, Version 2.0 (the "License");
 // you may not use this file except in compliance with the License.
 // You may obtain a copy of the License at
 //
 //     http://www.apache.org/licenses/LICENSE-2.0
 //
 // Unless required by applicable law or agreed to in writing, software
 // distributed under the License is distributed on an "AS IS" BASIS,
@@ skipping 16 matching lines @@
 #include "base/logging.h"
 #include "base/files/file_path.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/numerics/safe_conversions.h"
 #include "base/strings/string_util.h"
 #include "base/strings/utf_string_conversions.h"
 #include "build/build_config.h"
 #include "client/crash_report_database.h"
 #include "client/settings.h"
 #include "tools/tool_support.h"
+#include "util/file/basename.h"
 #include "util/file/file_io.h"
 #include "util/file/file_reader.h"
 #include "util/misc/uuid.h"
 
 #if defined(OS_MACOSX)
 #include <libgen.h>
 #endif  // OS_MACOSX
 
 namespace crashpad {
 namespace {
 
 #if defined(OS_POSIX)
 time_t TimeGM(struct tm* tm) {
   return timegm(tm);
 }
 
-std::string Basename(const std::string& path) {

[Mark Mentovai, 2015/05/04 21:21:58]

I’m skipping this for now because I suspect this is going to turn into a merge
conflict with its dependency change in any case.

[scottmg, 2015/05/05 19:26:22]

All gone now.

-  std::string copy(path);
-  return std::string(basename(&copy[0]));
-}
-
 const char* Strptime(const char* buf, const char* format, struct tm* tm) {
   return strptime(buf, format, tm);
 }
 #elif defined(OS_WIN)
 time_t TimeGM(struct tm* tm) {
   return _mkgmtime(tm);
 }
 
-std::string Basename(const std::string& path) {
-  char fname[_MAX_FNAME];
-  char ext[_MAX_EXT];
-  _splitpath(path.c_str(), nullptr, nullptr, fname, ext);
-  return std::string(fname) + std::string(ext);
-}
-
 const char* Strptime(const char* buf, const char* format, struct tm* tm) {
   // TODO(scottmg): strptime implementation.
   NOTREACHED();
   return nullptr;
 }
 #endif  // OS_POSIX
 
 void Usage(const std::string& me) {
   fprintf(stderr,
 "Usage: %s [OPTION]... PID\n"
@@ skipping 538 matching lines @@
 
   return EXIT_SUCCESS;
 }
 
 }  // namespace
 }  // namespace crashpad
 
 int main(int argc, char* argv[]) {
   return crashpad::DatabaseUtilMain(argc, argv);
 }