Get generate_dump compiling on Windows

tools/tool_support.h

 // Copyright 2014 The Crashpad Authors. All rights reserved.
 //
 // Licensed under the Apache License, Version 2.0 (the "License");
 // you may not use this file except in compliance with the License.
 // You may obtain a copy of the License at
 //
 //     http://www.apache.org/licenses/LICENSE-2.0
 //
 // Unless required by applicable law or agreed to in writing, software
 // distributed under the License is distributed on an "AS IS" BASIS,
@@ skipping 35 matching lines @@
   //! \copydoc Version
   static void Version(const std::string& me);
 
   //! \copydoc UsageTail
   static void UsageTail(const std::string& me);
 
   //! \copydoc UsageHint
   static void UsageHint(const std::string& me, const char* hint);
 #endif  // OS_POSIX
 
+#if defined(OS_WIN) || DOXYGEN
+  //! \brief Converts \a argv `wchar_t` UTF-16 to UTF-8, and passes onwards to a
+  //!     UTF-8 entry point.
+  //!
+  //! \return The return values of \a entry.

[Mark Mentovai, 2015/05/06 04:44:15]

value, singular.

[scottmg, 2015/05/06 18:02:18]

Done.

+  static int Wmain(int argc, wchar_t* argv[], int (*entry)(int, char*[]));
+#endif  // OS_WIN
+
+  //! \brief Convert a command line argument to the string type suitable for
+  //!     base::FilePath.
+  //!
+  //! On POSIX, this is a no-op. On Windows, we assume that Wmain was used, and

[Mark Mentovai, 2015/05/06 04:44:15]

Avoid “we.”

[Mark Mentovai, 2015/05/06 04:44:15]

Wmain(), also in the \sa.

[scottmg, 2015/05/06 18:02:18]

Done.

[scottmg, 2015/05/06 18:02:18]

Done.

+  //! the input argument was converted from UTF-16 in a `wchar_t*` to UTF-8 in a
+  //! `char*`. This undoes that transformation.
+  //!
+  //! \sa Wmain
+  static base::FilePath::StringType CommandLineArgumentToFilePathStringType(
+      const char* arg);

[Mark Mentovai, 2015/05/06 04:44:15]

Take a const std::string& here, because it’s going to be turned into one anyway,
and making the argument be a const string& instead of a const char* means that
it gets to keep its size if it’s a string to begin with.

Ideally this would actually be a const StringPiece&, but I didn’t have
StringPiece in mini_chromium when I added its utf_string_conversions.h. We do
have it now, though. We can make UTF8ToUTF16 accept a const StringPiece& instead
of a const string&, and then this can do the same.

[scottmg, 2015/05/06 18:02:18]

Done.

+
  private:
   DISALLOW_IMPLICIT_CONSTRUCTORS(ToolSupport);
 };
 
 }  // namespace crashpad
 
 #endif  // CRASHPAD_TOOLS_TOOL_SUPPORT_H_