Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Issue 1120313003: [New Multicolumn] Simplified layout also needs to mark spanner placeholders for layout. (Closed)

Created:
5 years, 7 months ago by mstensho (USE GERRIT)
Modified:
5 years, 7 months ago
CC:
blink-reviews, blink-reviews-rendering, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, mstensho (USE GERRIT), pdr+renderingwatchlist_chromium.org, zoltan1
Target Ref:
refs/remotes/origin/master
Project:
blink
Visibility:
Public.

Description

[New Multicolumn] Simplified layout also needs to mark spanner placeholders for layout. If the actual column-span:all object needs layout, so does the placeholder. There was code to ensure this for normal layout, but not for simplified layout (when we just want to drill into the tree and locate the containing block of some absolutely positioned object. BUG=483976 R=dsinclair@chromium.org,jchaffraix@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=194861

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -6 lines) Patch
A LayoutTests/fast/multicol/dynamic/relayout-abspos-in-relpos-spanner.html View 1 chunk +14 lines, -0 lines 0 comments Download
A LayoutTests/fast/multicol/dynamic/relayout-abspos-in-relpos-spanner-expected.html View 1 chunk +4 lines, -0 lines 0 comments Download
M Source/core/layout/LayoutBlock.cpp View 2 chunks +5 lines, -1 line 0 comments Download
M Source/core/layout/LayoutBlockFlow.cpp View 1 chunk +2 lines, -5 lines 0 comments Download
M Source/core/layout/LayoutMultiColumnSpannerPlaceholder.h View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
mstensho (USE GERRIT)
5 years, 7 months ago (2015-05-04 11:56:12 UTC) #1
dsinclair
lgtm
5 years, 7 months ago (2015-05-04 13:03:36 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1120313003/1
5 years, 7 months ago (2015-05-04 13:03:44 UTC) #4
commit-bot: I haz the power
5 years, 7 months ago (2015-05-04 13:06:38 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=194861

Powered by Google App Engine
This is Rietveld 408576698