Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(272)

Issue 11203: * Changed string-representation of regexps to handle unprintable chars. (Closed)

Created:
12 years, 1 month ago by Lasse Reichstein
Modified:
9 years, 6 months ago
CC:
v8-dev
Visibility:
Public.

Description

Characters in the range 0..31 and 128..65535 are now printed as \x or \u escapes. This allows tests written in C++ in a simple codepage to represent the output. Also avoids output containing \0, which ends string comparison. A small optimization on quantifiers on empty atoms.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+81 lines, -38 lines) Patch
M regexp2000/src/ast.h View 12 chunks +14 lines, -1 line 1 comment Download
M regexp2000/src/ast.cc View 3 chunks +29 lines, -13 lines 4 comments Download
M regexp2000/src/jsregexp.h View 1 chunk +1 line, -1 line 0 comments Download
M regexp2000/src/jsregexp.cc View 1 chunk +0 lines, -1 line 0 comments Download
M regexp2000/src/parser.cc View 2 chunks +14 lines, -0 lines 2 comments Download
M regexp2000/test/cctest/test-regexp.cc View 4 chunks +23 lines, -22 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Lasse Reichstein
Small code review, please.
12 years, 1 month ago (2008-11-17 10:36:20 UTC) #1
Christian Plesner Hansen
Lgtm http://codereview.chromium.org/11203/diff/1/2 File regexp2000/src/ast.cc (right): http://codereview.chromium.org/11203/diff/1/2#newcode257 Line 257: static void AddChar(StringStream* stream, uc16 character) { ...
12 years, 1 month ago (2008-11-17 10:54:35 UTC) #2
Lasse Reichstein
http://codereview.chromium.org/11203/diff/1/2 File regexp2000/src/ast.cc (right): http://codereview.chromium.org/11203/diff/1/2#newcode257 Line 257: static void AddChar(StringStream* stream, uc16 character) { "%k" ...
12 years, 1 month ago (2008-11-17 11:26:32 UTC) #3
Christian Plesner Hansen
12 years, 1 month ago (2008-11-17 11:37:45 UTC) #4
http://codereview.chromium.org/11203/diff/1/2
File regexp2000/src/ast.cc (right):

http://codereview.chromium.org/11203/diff/1/2#newcode257
Line 257: static void AddChar(StringStream* stream, uc16 character) {
Just change %k to do what you want.  Nothing depends on the current behavior.

Powered by Google App Engine
This is Rietveld 408576698