Make sure send one WebTouchEvent ack per ui::TouchEvent

content/browser/renderer_host/render_widget_host_view_aura.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/renderer_host/render_widget_host_view_aura.h"
 
 #include <set>
 
 #include "base/auto_reset.h"
 #include "base/basictypes.h"
@@ skipping 787 matching lines @@
   }
 #endif
 }
 
 void RenderWidgetHostViewAura::ParentHierarchyChanged() {
   ancestor_window_observer_.reset(new WindowAncestorObserver(this));
   // Snap when we receive a hierarchy changed. http://crbug.com/388908.
   HandleParentBoundsChanged();
 }
 
+void RenderWidgetHostViewAura::SetTouchPointStateStationary(

[jdduke (slow), 2015/05/07 15:20:28]

Hmm, ideally this would just be a free, nonmember function, see my comments in
the test. Maybe call this |MarkUnchangedTouchPointsAsStationary()|?

[lanwei, 2015/05/08 02:12:32]

Because I need to use this function in the unittest, so have to make it as a
member function.

[jdduke (slow), 2015/05/08 02:20:32]

Yeah, noticed that later, let's see what Tim says about needing to do the touch
bookkeeping.

+    blink::WebTouchEvent* event,
+    int touch_id) {

[jdduke (slow), 2015/05/07 15:20:28]

Maybe |changed_touch_id|?

[lanwei, 2015/05/08 02:12:32]

Done.

+  if (event->type == blink::WebInputEvent::TouchMove ||
+      event->type == blink::WebInputEvent::TouchCancel) {
+    for (size_t i = 0; i < event->touchesLength; ++i) {
+      if (event->touches[i].id != touch_id)
+        event->touches[i].state = blink::WebTouchPoint::StateStationary;
+    }
+  }
+}
+
 void RenderWidgetHostViewAura::MovePluginWindows(
     const std::vector<WebPluginGeometry>& plugin_window_moves) {
 #if defined(OS_WIN)
   // We need to clip the rectangle to the tab's viewport, otherwise we will draw
   // over the browser UI.
   if (!window_->GetRootWindow()) {
     DCHECK(plugin_window_moves.empty());
     return;
   }
   HWND parent = window_->GetHost()->GetAcceleratedWidget();
@@ skipping 458 matching lines @@
     case blink::WebInputEvent::TouchCancel:
       required_state = blink::WebTouchPoint::StateCancelled;
       break;
     default:
       required_state = blink::WebTouchPoint::StateUndefined;
       NOTREACHED();
       break;
   }
 
   // Only send acks for changed touches.
   for (size_t i = 0; i < touch.event.touchesLength; ++i) {

[jdduke (slow), 2015/05/07 15:20:28]

Should we be validating here that we only process one touch point per ack?

[lanwei, 2015/05/08 02:12:32]

Done.

     if (touch.event.touches[i].state == required_state)
       host->dispatcher()->ProcessedTouchEvent(window_, result);
   }
 }
 
 scoped_ptr<SyntheticGestureTarget>
 RenderWidgetHostViewAura::CreateSyntheticGestureTarget() {
   return scoped_ptr<SyntheticGestureTarget>(
       new SyntheticGestureTargetAura(host_));
 }
@@ skipping 880 matching lines @@
 
   blink::WebTouchEvent touch_event = ui::CreateWebTouchEventFromMotionEvent(
       pointer_state_, event->may_cause_scrolling());
   pointer_state_.CleanupRemovedTouchPoints(*event);
 
   // It is important to always mark events as being handled asynchronously when
   // they are forwarded. This ensures that the current event does not get
   // processed by the gesture recognizer before events currently awaiting
   // dispatch in the touch queue.
   event->DisableSynchronousHandling();
+
+  // Set unchange touch point to StateStationary for touchmove and
+  // touchcancel to make sure only send one ack per WebTouchEvent.
+  SetTouchPointStateStationary(&touch_event, event->touch_id());
   host_->ForwardTouchEventWithLatencyInfo(touch_event, *event->latency());
 }
 
 void RenderWidgetHostViewAura::OnGestureEvent(ui::GestureEvent* event) {
   TRACE_EVENT0("input", "RenderWidgetHostViewAura::OnGestureEvent");
   if ((event->type() == ui::ET_GESTURE_PINCH_BEGIN ||
       event->type() == ui::ET_GESTURE_PINCH_UPDATE ||
       event->type() == ui::ET_GESTURE_PINCH_END) && !pinch_zoom_enabled_) {
     event->SetHandled();
     return;
@@ skipping 567 matching lines @@
 
 ////////////////////////////////////////////////////////////////////////////////
 // RenderWidgetHostViewBase, public:
 
 // static
 void RenderWidgetHostViewBase::GetDefaultScreenInfo(WebScreenInfo* results) {
   GetScreenInfoForWindow(results, NULL);
 }
 
 }  // namespace content