Make EventHandler::ActiveIntervalTimer mockable.

Source/core/testing/TimerTest.cpp

Index: Source/core/testing/TimerTest.cpp
diff --git a/Source/core/testing/TimerTest.cpp b/Source/core/testing/TimerTest.cpp
new file mode 100644
index 0000000000000000000000000000000000000000..79fb445c0299d9bc940c62880e0be7045e2cf100
--- /dev/null
+++ b/Source/core/testing/TimerTest.cpp
@@ -0,0 +1,148 @@
+/*
+ * Copyright (C) 2013 Google Inc. All rights reserved.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions are
+ * met:
+ *
+ *     * Redistributions of source code must retain the above copyright
+ * notice, this list of conditions and the following disclaimer.
+ *     * Redistributions in binary form must reproduce the above
+ * copyright notice, this list of conditions and the following disclaimer
+ * in the documentation and/or other materials provided with the
+ * distribution.
+ *     * Neither the name of Google Inc. nor the names of its
+ * contributors may be used to endorse or promote products derived from
+ * this software without specific prior written permission.
+ *
+ * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
+ * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
+ * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
+ * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
+ * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
+ * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
+ * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
+ * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
+ * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
+ * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
+ * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+ */
+
+#include "config.h"
+#include "platform/Timer.h"
+
+#include "core/testing/UnitTestHelpers.h"
+#include <gtest/gtest.h>
+
+
+namespace {
+
+class Counter {
+public:
+    Counter()
+        : m_count(0) { }
+
+    void timerFired(WebCore::Timer<Counter>*) { m_count++; }
+    void reset() { m_count = 0; }
+    int count() const { return m_count; }
+
+private:
+    int m_count;
+};
+
+class MockableTimerTest : public ::testing::Test {
+public:
+    MockableTimerTest()
+        : m_counter()
+        , m_timer(&m_counter, &Counter::timerFired)
+    {
+    }
+
+    Counter m_counter;
+    WebCore::MockableTimer<Counter> m_timer;
+};
+
+TEST_F(MockableTimerTest, OneShotFire)
+{
+    ASSERT_EQ(0, m_counter.count());
+    ASSERT_FALSE(m_timer.inManualModeForTesting());
+    m_timer.startOneShot(0);
+    WebCore::testing::runPendingTasks();
+    ASSERT_EQ(1, m_counter.count());
+}
+
+TEST_F(MockableTimerTest, SuspendedFire)
+{
+    ASSERT_EQ(0, m_counter.count());
+    ASSERT_FALSE(m_timer.inManualModeForTesting());
+    m_timer.enterManualModeForTesting();
+    ASSERT_TRUE(m_timer.inManualModeForTesting());
+    m_timer.startOneShot(0);
+    WebCore::testing::runPendingTasks();
+    ASSERT_EQ(0, m_counter.count());
+}
+
+TEST_F(MockableTimerTest, ResumedFire)
+{
+    ASSERT_EQ(0, m_counter.count());
+    ASSERT_FALSE(m_timer.inManualModeForTesting());

[Rick Byers, 2014/01/10 21:46:50]

This repeats the two tests from above, right?  I'd either remove the above two
tests (combining them into this one), or just do the minimum necessary to get
back to the same state.

[Zeeshan Qureshi, 2014/01/10 22:20:41]

Yes, the last two tests are somewhat redundant, combining these 3 into one makes
sense.

+    m_timer.startOneShot(0);
+    WebCore::testing::runPendingTasks();
+    ASSERT_EQ(1, m_counter.count());
+
+    m_timer.enterManualModeForTesting();
+    ASSERT_TRUE(m_timer.inManualModeForTesting());
+    m_timer.startOneShot(0);
+    WebCore::testing::runPendingTasks();
+    ASSERT_EQ(1, m_counter.count());
+
+    m_timer.leaveManualModeForTesting();
+    ASSERT_FALSE(m_timer.inManualModeForTesting());
+    m_timer.startOneShot(0);
+    WebCore::testing::runPendingTasks();
+    ASSERT_EQ(2, m_counter.count());
+}
+
+TEST_F(MockableTimerTest, MockedOneShotFire)
+{
+    m_timer.enterManualModeForTesting();
+    m_timer.startOneShot(0);
+    ASSERT_TRUE(m_timer.isActive());
+    ASSERT_EQ(0, m_counter.count());
+    m_timer.manualFireForTesting();
+    ASSERT_FALSE(m_timer.isActive());
+    ASSERT_EQ(1, m_counter.count());
+    m_timer.startOneShot(0);
+    m_timer.manualFireForTesting();
+    ASSERT_EQ(2, m_counter.count());
+}
+
+TEST_F(MockableTimerTest, MockedRepeatingFire)
+{
+    m_timer.enterManualModeForTesting();
+    m_timer.startRepeating(1);
+    ASSERT_TRUE(m_timer.isActive());
+    ASSERT_EQ(0, m_counter.count());
+    m_timer.manualFireForTesting();
+    ASSERT_TRUE(m_timer.isActive());
+    ASSERT_EQ(1, m_counter.count());
+    m_timer.manualFireForTesting();
+    ASSERT_EQ(2, m_counter.count());
+}
+
+TEST_F(MockableTimerTest, FirePending)
+{
+    m_timer.enterManualModeForTesting();
+    m_timer.startOneShot(0);
+    ASSERT_TRUE(m_timer.isActive());
+    ASSERT_FALSE(m_timer.firePendingForTesting());
+    ASSERT_EQ(0, m_counter.count());
+    WebCore::testing::runPendingTasks();
+    ASSERT_FALSE(m_timer.isActive());
+    ASSERT_TRUE(m_timer.firePendingForTesting());
+    m_timer.manualFireForTesting();
+    ASSERT_FALSE(m_timer.firePendingForTesting());
+    ASSERT_EQ(1, m_counter.count());
+}
+
+} // namespace